MDL-31607 use full course object for require_login() if already available
This eliminates 1 db query.
This commit is contained in:
@@ -25,7 +25,7 @@ if (! $user = $DB->get_record("user", array("id"=>$userid))) {
|
||||
print_error('usermisconf', 'assignment');
|
||||
}
|
||||
|
||||
require_login($course->id, false, $cm);
|
||||
require_login($course, false, $cm);
|
||||
|
||||
$context = get_context_instance(CONTEXT_MODULE, $cm->id);
|
||||
if (($USER->id != $user->id) && !has_capability('mod/assignment:grade', $context)) {
|
||||
|
||||
@@ -842,7 +842,7 @@ class assignment_upload extends assignment_base {
|
||||
$mode = optional_param('mode', '', PARAM_ALPHA);
|
||||
$offset = optional_param('offset', 0, PARAM_INT);
|
||||
|
||||
require_login($this->course->id, false, $this->cm);
|
||||
require_login($this->course, false, $this->cm);
|
||||
|
||||
if (empty($mode)) {
|
||||
$urlreturn = 'view.php';
|
||||
|
||||
@@ -34,7 +34,7 @@ if (! $user = $DB->get_record('user', array('id'=>$userid))) {
|
||||
print_error("invaliduserid");
|
||||
}
|
||||
|
||||
require_login($course->id, false, $cm);
|
||||
require_login($course, false, $cm);
|
||||
|
||||
if (!has_capability('mod/assignment:grade', get_context_instance(CONTEXT_MODULE, $cm->id))) {
|
||||
print_error('cannotviewassignment', 'assignment');
|
||||
|
||||
Reference in New Issue
Block a user