From b25610f206e604966f249b13fd617bd3efe83911 Mon Sep 17 00:00:00 2001 From: Jun Pataleta Date: Mon, 20 Jun 2016 13:49:52 +0800 Subject: [PATCH] MDL-54924 tool_lp: Make the url property optional --- .../course_module_summary_exporter.php | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/admin/tool/lp/classes/external/course_module_summary_exporter.php b/admin/tool/lp/classes/external/course_module_summary_exporter.php index dfd24fd772b..e776a1a5082 100644 --- a/admin/tool/lp/classes/external/course_module_summary_exporter.php +++ b/admin/tool/lp/classes/external/course_module_summary_exporter.php @@ -40,14 +40,18 @@ class course_module_summary_exporter extends \core_competency\external\exporter } protected function get_other_values(renderer_base $output) { - $context = $this->related['cm']->context; + $cm = $this->related['cm']; + $context = $cm->context; - return array( - 'id' => $this->related['cm']->id, - 'name' => external_format_string($this->related['cm']->name, $context->id), - 'url' => $this->related['cm']->url->out(), - 'iconurl' => $this->related['cm']->get_icon_url()->out() + $values = array( + 'id' => $cm->id, + 'name' => external_format_string($cm->name, $context->id), + 'iconurl' => $cm->get_icon_url()->out() ); + if ($cm->url) { + $values['url'] = $cm->url->out(); + } + return $values; } @@ -60,7 +64,8 @@ class course_module_summary_exporter extends \core_competency\external\exporter 'type' => PARAM_TEXT ), 'url' => array( - 'type' => PARAM_URL + 'type' => PARAM_URL, + 'optional' => true, ), 'iconurl' => array( 'type' => PARAM_URL