From cc9a41608659dd76a40a35cfdcbf32aeaee9314b Mon Sep 17 00:00:00 2001 From: Aparup Banerjee Date: Mon, 7 Nov 2011 14:21:40 +0800 Subject: [PATCH] MDL-28670 webservice : added dimming of service name in security keys page if webservice is disabled or not on authorised list to access webservice. --- user/managetoken.php | 8 +++++++- webservice/lib.php | 4 ++-- webservice/renderer.php | 3 +++ 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/user/managetoken.php b/user/managetoken.php index 46cb3330173..58ac0fa2104 100644 --- a/user/managetoken.php +++ b/user/managetoken.php @@ -66,7 +66,13 @@ if ( !is_siteadmin($USER->id) if (empty($resetconfirmation)) { $webservice->generate_user_ws_tokens($USER->id); //generate all token that need to be generated $tokens = $webservice->get_user_ws_tokens($USER->id); - $webservicetokenboxhtml = $wsrenderer->user_webservice_tokens_box($tokens, $USER->id, + foreach ($tokens as $token) { + $authlist = $webservice->get_ws_authorised_user($token->wsid, $USER->id); + if(empty($authlist) && $token->restrictedusers) { + $token->enabled = false; + } + } + $webservicetokenboxhtml = $wsrenderer->user_webservice_tokens_box($tokens, $USER->id, $CFG->enablewsdocumentation); //display the box for web service token } } diff --git a/webservice/lib.php b/webservice/lib.php index 679ba3610f7..188007dc8e0 100644 --- a/webservice/lib.php +++ b/webservice/lib.php @@ -165,7 +165,7 @@ class webservice { } /** - * Return all ws user token + * Return all ws user token with ws enabled/disabled and ws restricted users mode. * @param integer $userid * @return array of token */ @@ -173,7 +173,7 @@ class webservice { global $DB; //here retrieve token list (including linked users firstname/lastname and linked services name) $sql = "SELECT - t.id, t.creatorid, t.token, u.firstname, u.lastname, s.name, t.validuntil + t.id, t.creatorid, t.token, u.firstname, u.lastname, s.id as wsid, s.name, s.enabled, s.restrictedusers, t.validuntil FROM {external_tokens} t, {user} u, {external_services} s WHERE diff --git a/webservice/renderer.php b/webservice/renderer.php index b6e32464b47..d3579934ceb 100644 --- a/webservice/renderer.php +++ b/webservice/renderer.php @@ -320,6 +320,9 @@ class core_webservice_renderer extends plugin_renderer_base { $validuntil = date("F j, Y"); //TODO: language support (look for moodle function) } + if (!$token->enabled) { //that is the (1 token-1ws) related ws is not enabled. + $token->name = ''.$token->name.''; + } $row = array($token->token, $token->name, $validuntil, $creatoratag, $reset); if ($documentation) {