MDL-21695 Making old_help_icon() deprecated

Some of the callers have never been fully implemented (help file never existed)
so I just dropped the help icon. In other cases, new help_icon() is
used. The help icons support in the messaging must be reviewed by the
subsystem maintainer.

user/groupaddnote.php

@@ -101,8 +101,6 @@ if (empty($users)) {
     }
 }
 
-$strpublishstate = get_string('publishstate', 'notes');
-
 $userlist = array();
 foreach ($users as $k => $v) {
     if (!$user = $DB->get_record('user', array('id'=>$v))) {
@@ -118,8 +116,9 @@ echo '</p>';
 echo '<p>' . get_string('content', 'notes');
 echo '<br /><textarea name="content" rows="5" cols="50">' . strip_tags(@$content) . '</textarea></p>';
 
-echo '<p>' . $strpublishstate;
-echo $OUTPUT->old_help_icon('status', $strpublishstate, 'notes');
+echo '<p>';
+echo get_string('publishstate', 'notes');
+echo $OUTPUT->help_icon('publishstate', 'notes');
 echo html_writer::select($state_names, 'state', empty($state) ? NOTES_STATE_PUBLIC : $state, false);
 echo '</p>';