L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-32251 E_STRICT fixes part 3

Browse Source
This commit is contained in:
Petr Skoda
2012-03-29 15:24:30 +02:00
parent 0bb48cc2a1
commit caee6e6c26
43 changed files with 236 additions and 185 deletions
Download Patch File Download Diff File Expand all files Collapse all files
question/engine/questionusage.php
+10 -2
View File
@@ -171,7 +171,8 @@ class question_usage_by_activity {
} else {
$this->questionattempts[] = $qa;
}
$qa->set_slot(end(array_keys($this->questionattempts)));
$ids = array_keys($this->questionattempts);
$qa->set_slot(end($ids));
$this->observer->notify_attempt_added($qa);
return $qa->get_slot();
}
@@ -510,7 +511,14 @@ class question_usage_by_activity {
* instead of the data from $_POST.
*/
public function process_all_actions($timestamp = null, $postdata = null) {
$slots = question_attempt::get_submitted_var('slots', PARAM_SEQUENCE, $postdata);
// note: we must not use "question_attempt::get_submitted_var()" because there is no attempt instance!!!
if (is_null($postdata)) {
$slots = optional_param('slots', null, PARAM_SEQUENCE);
} else if (array_key_exists('slots', $postdata)) {
$slots = clean_param($postdata['slots'], PARAM_SEQUENCE);
} else {
$slots = null;
}
if (is_null($slots)) {
$slots = $this->get_slots();
} else if (!$slots) {