MDL-32251 E_STRICT fixes part 3

This commit is contained in:
Petr Skoda
2012-03-29 15:24:30 +02:00
parent 0bb48cc2a1
commit caee6e6c26
43 changed files with 236 additions and 185 deletions
+4 -4
View File
@@ -1116,7 +1116,7 @@ class completion_info {
$groupjoin = "JOIN {groups_members} gm
ON gm.userid = u.id";
$groupselect = " AND gm.groupid = :groupid ";
$return->data['groupid'] = $groupid;
}
@@ -1249,9 +1249,9 @@ class completion_info {
// Grade being deleted, so only change could be to make it incomplete
$possibleresult = COMPLETION_INCOMPLETE;
} else {
$possibleresult = $this->internal_get_grade_state($item, $grade);
$possibleresult = self::internal_get_grade_state($item, $grade);
}
// OK, let's update state based on this
$this->update_state($cm, $possibleresult, $grade->userid);
}
@@ -1267,7 +1267,7 @@ class completion_info {
* @param grade_grade $grade an instance of grade_grade
* @return int Completion state e.g. COMPLETION_INCOMPLETE
*/
public function internal_get_grade_state($item, $grade) {
public static function internal_get_grade_state($item, $grade) {
if (!$grade) {
return COMPLETION_INCOMPLETE;
}