From faa121ad30628ca2eb84ac3bb724404d9922c2c6 Mon Sep 17 00:00:00 2001 From: Mathew May Date: Mon, 17 Apr 2023 11:24:51 +0800 Subject: [PATCH] MDL-76855 gradereport_user: Prevent parent access errors --- grade/report/user/classes/report/user.php | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/grade/report/user/classes/report/user.php b/grade/report/user/classes/report/user.php index d7ba977f33b..6f099ca912b 100644 --- a/grade/report/user/classes/report/user.php +++ b/grade/report/user/classes/report/user.php @@ -845,15 +845,17 @@ class user extends grade_report { } $this->gradeitemsdata[] = $gradeitemdata; } + + $parent = $gradeobject->load_parent_category(); + if ($gradeobject->is_category_item()) { + $parent = $parent->load_parent_category(); + } + // We collect the aggregation hints whether they are hidden or not. if ($this->showcontributiontocoursetotal) { $hint['grademax'] = $gradegrade->grade_item->grademax; $hint['grademin'] = $gradegrade->grade_item->grademin; $hint['grade'] = $gradeval; - $parent = $gradeobject->load_parent_category(); - if ($gradeobject->is_category_item()) { - $parent = $parent->load_parent_category(); - } $hint['parent'] = $parent->load_grade_item()->id; $this->aggregationhints[$gradegrade->itemid] = $hint; }