diff --git a/blocks/tags/lang/en/block_tags.php b/blocks/tags/lang/en/block_tags.php index 0643b911d66..265cd5aeec0 100644 --- a/blocks/tags/lang/en/block_tags.php +++ b/blocks/tags/lang/en/block_tags.php @@ -82,6 +82,7 @@ $string['pluginname'] = 'Tags'; $string['select'] = 'Select...'; $string['showcoursetags'] = 'Show course tags'; $string['showcoursetagsdef'] = 'Display the course tagging features in the tags block, allowing students to tag courses.'; +$string['suggestedtagthisunit'] = 'Suggested tag to this course:'; $string['tags'] = 'tags'; $string['tagthisunit'] = 'Tag this course:'; $string['tagunits'] = 'to tag your favourite courses'; diff --git a/tag/coursetags_edit.php b/tag/coursetags_edit.php index 53e6be65186..49930b11340 100644 --- a/tag/coursetags_edit.php +++ b/tag/coursetags_edit.php @@ -147,6 +147,7 @@ echo $OUTPUT->header(); // Print the add and delete form coursetag_get_jscript(); $edittagthisunit = get_string('edittagthisunit', $tagslang); + $suggestedtagthisunit = get_string('suggestedtagthisunit', $tagslang); $arrowtitle = get_string('arrowtitle', $tagslang); $sesskey = sesskey(); $leftarrow = $OUTPUT->pix_url('t/arrow_left'); @@ -159,12 +160,19 @@ echo $OUTPUT->header();
- $edittagthisunit +
- +
+
+
+
+
+ +
+
@@ -182,10 +190,12 @@ EOT; $outstr .= <<
- $editdeletemytag +
- $selectoptions
diff --git a/tag/locallib.php b/tag/locallib.php index 095bbda04a2..158524c72f3 100644 --- a/tag/locallib.php +++ b/tag/locallib.php @@ -233,6 +233,7 @@ function tag_print_search_box($return=false) { $output = $OUTPUT->box_start('','tag-search-box'); $output .= '
'; $output .= '
'; + $output .= ''; $output .= ''; $output .= '
'; $output .= '
'; diff --git a/tag/manage.php b/tag/manage.php index 2a886d3c7aa..ad3cafeb969 100644 --- a/tag/manage.php +++ b/tag/manage.php @@ -246,6 +246,7 @@ $totalcount = $DB->count_records_sql(" $table->initialbars(true); // always initial bars $table->pagesize($perpage, $totalcount); +//@todo MDL-35474 convert to mform echo '
'; //retrieve tags from DB @@ -253,25 +254,32 @@ if ($tagrecords = $DB->get_records_sql($query, $params, $table->get_page_start() //populate table with data foreach ($tagrecords as $tag) { - $id = $tag->id; - $name = ''. tag_display_name($tag) .''; - $owner = '' . fullname($tag) . ''; - $count = $tag->count; - $flag = $tag->flag; - $timemodified = format_time(time() - $tag->timemodified); - $checkbox = ''; - $text = ''; - $tagtype = html_writer::select($existing_tagtypes, 'tagtypes['.$tag->id.']', $tag->tagtype, false); + $id = $tag->id; + $params = array('id' => $tag->id); + $taglink = new moodle_url($CFG->wwwroot . '/tag/index.php', $params); + $name = html_writer::link($taglink, tag_display_name($tag)); + $params = array('id' => $tag->owner); + $ownerlink = new moodle_url($CFG->wwwroot . '/user/view.php', $params); + $owner = html_writer::link($ownerlink, fullname($tag)); + $count = $tag->count; + $flag = $tag->flag; + $timemodified = format_time(time() - $tag->timemodified); + $checkbox = html_writer::tag('input', '', array('type' => 'checkbox', 'name' => 'tagschecked[]', 'value' => $tag->id)); + $attrs = array('type' => 'text', 'id' => 'newname_' . $tag->id, 'name' => 'newname["'.$tag->id.'"]'); + $text = html_writer::label(get_string('newname', 'tag'), 'newname_' . $tag->id, false, array('class' => 'accesshide')); + $text .= html_writer::empty_tag('input', $attrs); + $tagtype = html_writer::label(get_string('tagtype', 'tag'), 'menutagtypes'. $tag->id, false, array('class' => 'accesshide')); + $tagtype .= html_writer::select($existing_tagtypes, 'tagtypes['.$tag->id.']', $tag->tagtype, false, array('id' => 'menutagtypes'. $tag->id)); //if the tag if flagged, highlight it if ($tag->flag > 0) { - $id = '' . $id . ''; - $name = '' . $name . ''; - $owner = '' . $owner . ''; - $count = '' . $count . ''; - $flag = '' . $flag . ''; - $timemodified = '' . $timemodified . ''; - $tagtype = ''. $tagtype. ''; + $id = html_writer::tag('span', $id, array('class' => 'flagged-tag')); + $name = html_writer::tag('span', $name, array('class' => 'flagged-tag')); + $owner = html_writer::tag('span', $owner, array('class' => 'flagged-tag')); + $count = html_writer::tag('span', $count, array('class' => 'flagged-tag')); + $flag = html_writer::tag('span', $flag, array('class' => 'flagged-tag')); + $timemodified = html_writer::tag('span', $timemodified, array('class' => 'flagged-tag')); + $tagtype = html_writer::tag('span', $tagtype, array('class' => 'flagged-tag')); } $data = array($id, $name, $owner, $count, $flag, $timemodified, $text, $tagtype, $checkbox); @@ -279,31 +287,43 @@ if ($tagrecords = $DB->get_records_sql($query, $params, $table->get_page_start() $table->add_data($data); } - echo ' '; - echo ' '; - echo ' '; - echo '

'; - echo ''; + echo html_writer::empty_tag('input', array('type' => 'button', 'onclick' => 'checkall()', 'value' => get_string('selectall'))); + echo html_writer::empty_tag('input', array('type' => 'button', 'onclick' => 'checknone()', 'value' => get_string('deselectall'))); + echo html_writer::empty_tag('input', array('type' => 'hidden', 'name' => 'sesskey', 'value' => sesskey())); + echo html_writer::empty_tag('br'); + echo html_writer::empty_tag('br'); - echo ''; + echo html_writer::label(get_string('withselectedtags', 'tag'), 'menuformaction', false, array('class' => 'accesshide')); + $options = array('' => get_string('withselectedtags', 'tag'), + 'reset' => get_string('resetflag', 'tag'), + 'delete' => get_string('delete', 'tag'), + 'changetype' => get_string('changetype', 'tag'), + 'changename' => get_string('changename', 'tag')); + echo html_writer::select($options, 'action', '', array(), array('id' => 'menuformaction')); + + echo html_writer::tag('button', get_string('ok'), array('id' => 'tag-management-submit', 'type' => 'submit')); } $table->print_html(); + +//@todo MDL-35474 convert to mform echo '
'; if ($perpage == SHOW_ALL_PAGE_SIZE) { - echo ''; + echo html_writer::start_tag('div', array('id' => 'showall')); + $params = array('perpage' => DEFAULT_PAGE_SIZE); + $url = new moodle_url($baseurl, $params); + echo html_writer::link($url, get_string('showperpage', '', DEFAULT_PAGE_SIZE)); + echo html_writer::end_tag('div'); } else if ($totalcount > 0 and $perpage < $totalcount) { - echo ''; + echo html_writer::start_tag('div', array('id' => 'showall')); + $params = array('perpage' => SHOW_ALL_PAGE_SIZE); + $url = new moodle_url($baseurl, $params); + echo html_writer::link($url, get_string('showall', '', $totalcount)); + echo html_writer::end_tag('div'); } -echo '
'; +echo html_writer::empty_tag('br'); echo $OUTPUT->footer();