diff --git a/mod/quiz/report/overview/report.php b/mod/quiz/report/overview/report.php index fc412ee125d..07c1743f929 100644 --- a/mod/quiz/report/overview/report.php +++ b/mod/quiz/report/overview/report.php @@ -55,6 +55,14 @@ class quiz_report extends quiz_default_report { break; } + // Set table options + $noattempts = optional_param('noattempts', 0, PARAM_INT); + $detailedmarks = optional_param('detailedmarks', 0, PARAM_INT); + $pagesize = optional_param('pagesize', 10, PARAM_INT); + $reporturl = $CFG->wwwroot.'/mod/quiz/report.php?mode=overview'; + $reporturlwithoptions = $reporturl . '&id=' . $cm->id . '&noattempts=' . $noattempts . + '&detailedmarks=' . $detailedmarks . '&pagesize=' . $pagesize; + // Print information on the number of existing attempts if (!$download) { //do not print notices when downloading if ($attemptnum = count_records('quiz_attempts', 'quiz', $quiz->id, 'preview', 0)) { @@ -71,7 +79,7 @@ class quiz_report extends quiz_default_report { /// find out current groups mode if ($groupmode = groupmode($course, $cm)) { // Groups are being used if (!$download) { - $currentgroup = setup_and_print_groups($course, $groupmode, "report.php?id=$cm->id&mode=overview"); + $currentgroup = setup_and_print_groups($course, $groupmode, $reporturlwithoptions); } else { $currentgroup = get_and_set_current_group($course, $groupmode); } @@ -79,10 +87,6 @@ class quiz_report extends quiz_default_report { $currentgroup = get_and_set_current_group($course, $groupmode); } - // Set table options - $noattempts = optional_param('noattempts', 0, PARAM_INT); - $detailedmarks = optional_param('detailedmarks', 0, PARAM_INT); - $pagesize = optional_param('pagesize', 10, PARAM_INT); $hasfeedback = quiz_has_feedback($quiz->id) && $quiz->grade > 1.e-7 && $quiz->sumgrades > 1.e-7; if ($pagesize < 1) { $pagesize = 10; @@ -144,9 +148,7 @@ class quiz_report extends quiz_default_report { $table->define_columns($tablecolumns); $table->define_headers($tableheaders); - $table->define_baseurl($CFG->wwwroot.'/mod/quiz/report.php?mode=overview&id=' . - $cm->id . '&noattempts=' . $noattempts . '&detailedmarks=' . $detailedmarks . - '&pagesize=' . $pagesize); + $table->define_baseurl($reporturlwithoptions); $table->sortable(true); $table->collapsible(true); @@ -501,10 +503,8 @@ class quiz_report extends quiz_default_report { if (!$download) { // Start form echo '