L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-79291 h5p: handle content type creation errors in test generator.

Browse Source 
If the endpoint is temporarily down and/or misbehaving, then at least
we'll a clearer failure message.
This commit is contained in:
Paul Holden
2023-09-07 15:38:45 +01:00
parent 00f0613f99
commit c7d08f855e
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
h5p/tests/generator/lib.php
+7 -2
View File
@@ -400,6 +400,8 @@ class core_h5p_generator extends \component_generator_base {
* @param array $typestonotinstall H5P content types that should not be installed * @param array $typestonotinstall H5P content types that should not be installed
* @param core $core h5p_test_core instance required to use the exttests URL * @param core $core h5p_test_core instance required to use the exttests URL
* @return array Data of the content types not installed. * @return array Data of the content types not installed.
*
* @throws invalid_response_exception If request to get the latest content types fails (usually due to a transient error)
*/ */
public function create_content_types(array $typestonotinstall, core $core): array { public function create_content_types(array $typestonotinstall, core $core): array {
global $DB; global $DB;
@@ -407,12 +409,15 @@ class core_h5p_generator extends \component_generator_base {
autoloader::register(); autoloader::register();
// Get info of latest content types versions. // Get info of latest content types versions.
$contenttypes = $core->get_latest_content_types()->contentTypes; $response = $core->get_latest_content_types();
if (!empty($response->error)) {
throw new invalid_response_exception($response->error);
}
$installedtypes = 0; $installedtypes = 0;
// Fake installation of all other H5P content types. // Fake installation of all other H5P content types.
foreach ($contenttypes as $contenttype) { foreach ($response->contentTypes as $contenttype) {
// Don't install pending content types. // Don't install pending content types.
if (in_array($contenttype->id, $typestonotinstall)) { if (in_array($contenttype->id, $typestonotinstall)) {
continue; continue;