From a94bc886bbaedb77d782a2e07ff2f3172de4d59b Mon Sep 17 00:00:00 2001 From: Matteo Scaramuccia Date: Sun, 25 Aug 2013 14:00:47 +0200 Subject: [PATCH] MDL-41410 Caching: move comment to the appropriate place. MDL-38162 fixes the issue about testing the connection to the memcached daemon, which means testing once the connection to the pool of servers and not to each of the servers while being added to the pool. It misses to move the comment to that code too. --- cache/stores/memcache/lib.php | 2 +- cache/stores/memcached/lib.php | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/cache/stores/memcache/lib.php b/cache/stores/memcache/lib.php index 2e104bd6385..1569da6bd80 100644 --- a/cache/stores/memcache/lib.php +++ b/cache/stores/memcache/lib.php @@ -132,8 +132,8 @@ class cachestore_memcache extends cache_store implements cache_is_configurable { $this->connection = new Memcache; foreach ($this->servers as $server) { $this->connection->addServer($server[0], $server[1], true, $server[2]); - // Test the connection to this server. } + // Test the connection to the pool of servers. $this->isready = @$this->connection->set($this->parse_key('ping'), 'ping', MEMCACHE_COMPRESSED, 1); } diff --git a/cache/stores/memcached/lib.php b/cache/stores/memcached/lib.php index a74dc83e053..508628e3883 100644 --- a/cache/stores/memcached/lib.php +++ b/cache/stores/memcached/lib.php @@ -141,6 +141,7 @@ class cachestore_memcached extends cache_store implements cache_is_configurable } $this->connection->addServers($this->servers); } + // Test the connection to the pool of servers. $this->isready = @$this->connection->set("ping", 'ping', 1); }