From c603457381b8d641e2539855221b744e2dfa76e8 Mon Sep 17 00:00:00 2001
From: Jonathan Harker <jonathan@catalyst.net.nz>
Date: Mon, 19 Jul 2010 05:19:47 +0000
Subject: [PATCH] mod/data MDL-23284 fix database error that was chewing up
 HTML output.

Author: Jonathan Harker <jonathan@catalyst.net.nz>
---
 mod/data/field/latlong/mod.html | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mod/data/field/latlong/mod.html b/mod/data/field/latlong/mod.html
index 7cf519bf39e..78da39f44fc 100755
--- a/mod/data/field/latlong/mod.html
+++ b/mod/data/field/latlong/mod.html
@@ -29,14 +29,14 @@
             <option value="-2"<?php if($this->field->param2==-2) echo ' selected="selected"' ?>><?php echo get_string('latitude', 'data').'/'.get_string('longitude', 'data') ?></option>
             <?php
                 // Fetch all "suitable" other fields that exist for this database
-                $textfields = $DB->get_records_select('data_fields', array('dataid'=>$this->data->id, 'type'=>'text'));
-                echo '<optgroup label="'.get_string('latlongotherfields', 'data').':">';
+                $textfields = $DB->get_records_select('data_fields', 'dataid = :dataid and type = :type', array('dataid'=>$this->data->id, 'type'=>'text'));
                 if(sizeof($textfields)>0) {
+                echo '<optgroup label="'.get_string('latlongotherfields', 'data').':">';
                     foreach($textfields as $textfield) {
                         echo "<option value='$textfield->id'".($this->field->param2==$textfield->id ? ' selected="selected"' : '').">$textfield->name</option>";
                     }
-                }
                 echo '</optgroup>';
+                }
             ?>
           </select>
         </td>