From c598ea55fe41ac68003a0d60a1b414e0d8007343 Mon Sep 17 00:00:00 2001 From: Frederic Massart Date: Mon, 21 May 2012 13:00:31 +0800 Subject: [PATCH] MDL-32981 Filepicker: my private files uses edit page instead of view --- lib/navigationlib.php | 2 +- user/filesedit.php | 12 +++++------- user/filesedit_form.php | 7 ++++--- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/lib/navigationlib.php b/lib/navigationlib.php index 707ea920e05..9710c66b189 100644 --- a/lib/navigationlib.php +++ b/lib/navigationlib.php @@ -2305,7 +2305,7 @@ class global_navigation extends navigation_node { $context = get_context_instance(CONTEXT_USER, $USER->id); if ($iscurrentuser && has_capability('moodle/user:manageownfiles', $context)) { - $url = new moodle_url('/user/files.php'); + $url = new moodle_url('/user/filesedit.php'); $usernode->add(get_string('myfiles'), $url, self::TYPE_SETTING); } diff --git a/user/filesedit.php b/user/filesedit.php index ab34eef78a8..2438f73002e 100644 --- a/user/filesedit.php +++ b/user/filesedit.php @@ -33,13 +33,11 @@ if (isguestuser()) { } $returnurl = optional_param('returnurl', '', PARAM_URL); +$returnbutton = true; if (empty($returnurl)) { - if (!empty($_SERVER["HTTP_REFERER"])) { - $returnurl = $_SERVER["HTTP_REFERER"]; - } else { - $returnurl = new moodle_url('/user/files.php'); - } + $returnbutton = false; + $returnurl = new moodle_url('/user/filesedit.php'); } $context = get_context_instance(CONTEXT_USER, $USER->id); @@ -48,7 +46,7 @@ require_capability('moodle/user:manageownfiles', $context); $title = get_string('myfiles'); $struser = get_string('user'); -$PAGE->set_url('/user/files.php'); +$PAGE->set_url('/user/filesedit.php'); $PAGE->set_context($context); $PAGE->set_title($title); $PAGE->set_heading($title); @@ -60,7 +58,7 @@ $data->returnurl = $returnurl; $options = array('subdirs'=>1, 'maxbytes'=>$CFG->userquota, 'maxfiles'=>-1, 'accepted_types'=>'*', 'return_types'=>FILE_INTERNAL); file_prepare_standard_filemanager($data, 'files', $options, $context, 'user', 'private', 0); -$mform = new user_filesedit_form(null, array('data'=>$data, 'options'=>$options)); +$mform = new user_filesedit_form(null, array('data'=>$data, 'options'=>$options, 'cancelbutton'=>$returnbutton)); if ($mform->is_cancelled()) { redirect($returnurl); diff --git a/user/filesedit_form.php b/user/filesedit_form.php index 4fd1e6f1b5e..13cc0418c3e 100644 --- a/user/filesedit_form.php +++ b/user/filesedit_form.php @@ -31,13 +31,14 @@ class user_filesedit_form extends moodleform { function definition() { $mform = $this->_form; - $data = $this->_customdata['data']; - $options = $this->_customdata['options']; + $data = $this->_customdata['data']; + $options = $this->_customdata['options']; + $cancelbutton = isset($this->_customdata['cancelbutton']) ? $this->_customdata['cancelbutton'] : true; $mform->addElement('filemanager', 'files_filemanager', get_string('files'), null, $options); $mform->addElement('hidden', 'returnurl', $data->returnurl); - $this->add_action_buttons(true, get_string('savechanges')); + $this->add_action_buttons($cancelbutton, get_string('savechanges')); $this->set_data($data); }