From 6d3dca55f8a9c9cf2338e747faf5ce1240edc923 Mon Sep 17 00:00:00 2001 From: Josh Ebarvia Date: Sat, 11 Jul 2020 15:02:12 +0930 Subject: [PATCH 1/2] MDL-69253 mod_quiz: Fix timecreated is 0 when creating a quiz activity --- mod/quiz/lib.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mod/quiz/lib.php b/mod/quiz/lib.php index 4d04f020579..44863066e9a 100644 --- a/mod/quiz/lib.php +++ b/mod/quiz/lib.php @@ -84,7 +84,7 @@ function quiz_add_instance($quiz) { $cmid = $quiz->coursemodule; // Process the options from the form. - $quiz->created = time(); + $quiz->timecreated = time(); $result = quiz_process_options($quiz); if ($result && is_string($result)) { return $result; From b1341895b15d8b9d1484fe55e1e76eb26f2ae304 Mon Sep 17 00:00:00 2001 From: Tim Hunt Date: Tue, 4 Aug 2020 14:00:30 +0100 Subject: [PATCH 2/2] MDL-69253 mod_quiz: unit test for the last commit --- mod/quiz/tests/generator_test.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mod/quiz/tests/generator_test.php b/mod/quiz/tests/generator_test.php index 4ae705ad677..94e7ca70b95 100644 --- a/mod/quiz/tests/generator_test.php +++ b/mod/quiz/tests/generator_test.php @@ -49,7 +49,8 @@ class mod_quiz_generator_testcase extends advanced_testcase { $generator->create_instance(array('course'=>$SITE->id)); $generator->create_instance(array('course'=>$SITE->id)); - $quiz = $generator->create_instance(array('course'=>$SITE->id)); + $createtime = time(); + $quiz = $generator->create_instance(array('course' => $SITE->id, 'timecreated' => 0)); $this->assertEquals(3, $DB->count_records('quiz')); $cm = get_coursemodule_from_instance('quiz', $quiz->id); @@ -59,5 +60,8 @@ class mod_quiz_generator_testcase extends advanced_testcase { $context = context_module::instance($cm->id); $this->assertEquals($quiz->cmid, $context->instanceid); + + $this->assertEqualsWithDelta($createtime, + $DB->get_field('quiz', 'timecreated', ['id' => $cm->instance]), 2); } }