From c332400ba6add1bf7d34e26668cace4b0732ecf2 Mon Sep 17 00:00:00 2001 From: Shamim Rezaie Date: Wed, 8 Apr 2020 11:32:36 +1000 Subject: [PATCH] MDL-68148 user: remove the noscript tag The submit button remains deactive if js is disabled. So having a noscript tag to output a submit button here does not make sense. --- user/index.php | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/user/index.php b/user/index.php index 6ca32cf4219..b8b07c14923 100644 --- a/user/index.php +++ b/user/index.php @@ -338,14 +338,12 @@ if ($bulkoperations) { 'data-toggle' => 'action', 'disabled' => empty($selectall) ); - echo html_writer::tag('div', html_writer::tag('label', get_string("withselectedusers"), - array('for' => 'formactionid', 'class' => 'col-form-label d-inline')) . - html_writer::select($displaylist, 'formaction', '', array('' => 'choosedots'), $selectactionparams)); + $label = html_writer::tag('label', get_string("withselectedusers"), + ['for' => 'formactionid', 'class' => 'col-form-label d-inline']); + $select = html_writer::select($displaylist, 'formaction', '', ['' => 'choosedots'], $selectactionparams); + echo html_writer::tag('div', $label . $select); - echo ''; - echo ''; + echo ''; echo ''; echo '';