From c2d26f8a7ba9eb6f391f7c970bbd98de963d071c Mon Sep 17 00:00:00 2001
From: Paul Holden <paulh@moodle.com>
Date: Wed, 9 Nov 2022 18:39:10 +0000
Subject: [PATCH] MDL-76250 mod_assign: disable form change checker for grading
 options.

This was previously fixed in 8e9efe60, but seems to have regressed
somewhere along the way.
---
 mod/assign/gradingoptionsform.php | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/mod/assign/gradingoptionsform.php b/mod/assign/gradingoptionsform.php
index db15a86f84a..92ab849f918 100644
--- a/mod/assign/gradingoptionsform.php
+++ b/mod/assign/gradingoptionsform.php
@@ -42,7 +42,8 @@ class mod_assign_grading_options_form extends moodleform {
     public function definition() {
         $mform = $this->_form;
         $instance = $this->_customdata;
-        $dirtyclass = array('class' => 'ignoredirty');
+
+        $mform->disable_form_change_checker();
 
         $mform->addElement('header', 'general', get_string('gradingoptions', 'assign'));
         // Visible elements.
@@ -56,7 +57,7 @@ class mod_assign_grading_options_form extends moodleform {
                 }
             }
         }
-        $mform->addElement('select', 'perpage', get_string('assignmentsperpage', 'assign'), $options, $dirtyclass);
+        $mform->addElement('select', 'perpage', get_string('assignmentsperpage', 'assign'), $options);
         $options = array('' => get_string('filternone', 'assign'),
                          ASSIGN_FILTER_NOT_SUBMITTED => get_string('filternotsubmitted', 'assign'),
                          ASSIGN_FILTER_DRAFT => get_string('filterdraft', 'assign'),
@@ -64,33 +65,33 @@ class mod_assign_grading_options_form extends moodleform {
                          ASSIGN_FILTER_REQUIRE_GRADING => get_string('filterrequiregrading', 'assign'),
                          ASSIGN_FILTER_GRANTED_EXTENSION => get_string('filtergrantedextension', 'assign'));
         if ($instance['submissionsenabled']) {
-            $mform->addElement('select', 'filter', get_string('filter', 'assign'), $options, $dirtyclass);
+            $mform->addElement('select', 'filter', get_string('filter', 'assign'), $options);
         }
         if (!empty($instance['markingallocationopt'])) {
             $markingfilter = get_string('markerfilter', 'assign');
-            $mform->addElement('select', 'markerfilter', $markingfilter, $instance['markingallocationopt'], $dirtyclass);
+            $mform->addElement('select', 'markerfilter', $markingfilter, $instance['markingallocationopt']);
         }
         if (!empty($instance['markingworkflowopt'])) {
             $workflowfilter = get_string('workflowfilter', 'assign');
-            $mform->addElement('select', 'workflowfilter', $workflowfilter, $instance['markingworkflowopt'], $dirtyclass);
+            $mform->addElement('select', 'workflowfilter', $workflowfilter, $instance['markingworkflowopt']);
         }
         // Quickgrading.
         if ($instance['showquickgrading']) {
-            $mform->addElement('checkbox', 'quickgrading', get_string('quickgrading', 'assign'), '', $dirtyclass);
+            $mform->addElement('checkbox', 'quickgrading', get_string('quickgrading', 'assign'));
             $mform->addHelpButton('quickgrading', 'quickgrading', 'assign');
             $mform->setDefault('quickgrading', $instance['quickgrading']);
         }
 
         // Show active/suspended user option.
         if ($instance['showonlyactiveenrolopt']) {
-            $mform->addElement('checkbox', 'showonlyactiveenrol', get_string('showonlyactiveenrol', 'grades'), '', $dirtyclass);
+            $mform->addElement('checkbox', 'showonlyactiveenrol', get_string('showonlyactiveenrol', 'grades'));
             $mform->addHelpButton('showonlyactiveenrol', 'showonlyactiveenrol', 'grades');
             $mform->setDefault('showonlyactiveenrol', $instance['showonlyactiveenrol']);
         }
 
         // Place student downloads in seperate folders.
         if ($instance['submissionsenabled']) {
-            $mform->addElement('checkbox', 'downloadasfolders', get_string('downloadasfolders', 'assign'), '', $dirtyclass);
+            $mform->addElement('checkbox', 'downloadasfolders', get_string('downloadasfolders', 'assign'));
             $mform->addHelpButton('downloadasfolders', 'downloadasfolders', 'assign');
             $mform->setDefault('downloadasfolders', $instance['downloadasfolders']);
         }