From c29501c06d714b6053d1f97e592aa83d470c0c9a Mon Sep 17 00:00:00 2001 From: Damyon Wiese Date: Wed, 22 Nov 2017 15:35:20 +0800 Subject: [PATCH] MDL-59970 competencies: performance Remove useless get_records call in get_least_proficient_competencies_for_course function. On big sites this would cause huge memory usage. --- competency/classes/user_competency_course.php | 1 - 1 file changed, 1 deletion(-) diff --git a/competency/classes/user_competency_course.php b/competency/classes/user_competency_course.php index 392e1c52278..ad97f6cb011 100644 --- a/competency/classes/user_competency_course.php +++ b/competency/classes/user_competency_course.php @@ -282,7 +282,6 @@ class user_competency_course extends persistent { ORDER BY p.timesproficient ASC, c.id DESC'; $results = $DB->get_records_sql($sql, $params, $skip, $limit); - $a = $DB->get_records_sql('SELECT * from {' . self::TABLE . '}'); $comps = array(); foreach ($results as $r) {