diff --git a/grade/edit/tree/item.php b/grade/edit/tree/item.php index 673c9241154..6db3b6c5a99 100644 --- a/grade/edit/tree/item.php +++ b/grade/edit/tree/item.php @@ -125,15 +125,15 @@ if ($data = $mform->get_data(false)) { $grade_item->itemtype = 'manual'; // all new items to be manual only $grade_item->insert(); + // set parent if needed + if (isset($data->parentcategory)) { + $grade_item->set_parent($data->parentcategory, 'gradebook'); + } + } else { $grade_item->update(); } - // set parent if needed - if (isset($data->parentcategory)) { - $grade_item->set_parent($data->parentcategory, 'gradebook'); - } - // update hiding flag if ($hiddenuntil) { $grade_item->set_hidden($hiddenuntil, false); diff --git a/grade/edit/tree/outcomeitem.php b/grade/edit/tree/outcomeitem.php index bc6334feab7..c6df5398027 100644 --- a/grade/edit/tree/outcomeitem.php +++ b/grade/edit/tree/outcomeitem.php @@ -186,10 +186,6 @@ if ($data = $mform->get_data(false)) { } else { $grade_item->update(); - // set parent if needed - if (isset($data->parentcategory)) { - $grade_item->set_parent($data->parentcategory, 'gradebook'); - } } // update hiding flag