From c224a6c65daf28eb9263fbfbc6315dba5844bf55 Mon Sep 17 00:00:00 2001
From: Neill Magill <neill.magill@nottingham.ac.uk>
Date: Tue, 18 Jun 2024 08:52:57 +0100
Subject: [PATCH] MDL-82214 admin: Settings should not change when in read only
 mode

Before this change if some settings were:

* read only
* visible on a settings page
* are set or have values selected

when the settings page was saved the setting would be set tobe empty,
because the hidden input remained on the page, while the other inputs
where not posted to Moodle.
---
 admin/templates/setting_configcheckbox.mustache             | 2 +-
 admin/templates/setting_configmulticheckbox.mustache        | 2 +-
 admin/templates/setting_configmultiselect.mustache          | 2 +-
 admin/templates/setting_configmultiselect_optgroup.mustache | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/admin/templates/setting_configcheckbox.mustache b/admin/templates/setting_configcheckbox.mustache
index 48e0471ee27..8efecf36f10 100644
--- a/admin/templates/setting_configcheckbox.mustache
+++ b/admin/templates/setting_configcheckbox.mustache
@@ -38,6 +38,6 @@
     }
 }}
 <div class="form-checkbox defaultsnext">
-    <input type="hidden" name="{{name}}" value="{{no}}">
+    {{^readonly}}<input type="hidden" name="{{name}}" value="{{no}}">{{/readonly}}
     <input {{#readonly}}disabled{{/readonly}} type="checkbox" name="{{name}}" value="{{value}}" id="{{id}}" {{#checked}}checked{{/checked}}>
 </div>
diff --git a/admin/templates/setting_configmulticheckbox.mustache b/admin/templates/setting_configmulticheckbox.mustache
index a14172ea664..4eaa69eee1a 100644
--- a/admin/templates/setting_configmulticheckbox.mustache
+++ b/admin/templates/setting_configmulticheckbox.mustache
@@ -35,7 +35,7 @@
     }
 }}
 <div class="form-multicheckbox">
-    <input type="hidden" name="{{name}}[xxxxx]" value="1">
+    {{^readonly}}<input type="hidden" name="{{name}}[xxxxx]" value="1">{{/readonly}}
     {{#hasoptions}}
         <ul>
             {{#options}}
diff --git a/admin/templates/setting_configmultiselect.mustache b/admin/templates/setting_configmultiselect.mustache
index c19b1fd7f8b..e105478035b 100644
--- a/admin/templates/setting_configmultiselect.mustache
+++ b/admin/templates/setting_configmultiselect.mustache
@@ -40,7 +40,7 @@
     Setting configmultiselect.
 }}
 <div class="form-select">
-    <input type="hidden" name="{{name}}[xxxxx]" value="1">
+    {{^readonly}}<input type="hidden" name="{{name}}[xxxxx]" value="1">{{/readonly}}
     <select {{#readonly}}disabled{{/readonly}} id="{{id}}" name="{{name}}[]" size="{{size}}" class="form-control" multiple>
         {{#options}}
             <option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
diff --git a/admin/templates/setting_configmultiselect_optgroup.mustache b/admin/templates/setting_configmultiselect_optgroup.mustache
index a1cbc9d7ee3..7663d5dfb0f 100644
--- a/admin/templates/setting_configmultiselect_optgroup.mustache
+++ b/admin/templates/setting_configmultiselect_optgroup.mustache
@@ -59,7 +59,7 @@
     Setting configmultiselect with optgroup support.
 }}
 <div class="form-select">
-    <input type="hidden" name="{{name}}[xxxxx]" value="1">
+    {{^readonly}}<input type="hidden" name="{{name}}[xxxxx]" value="1">{{/readonly}}
     <select {{#readonly}}disabled{{/readonly}} id="{{id}}" name="{{name}}[]" size="{{size}}" class="form-control" multiple>
     {{#options}}
         <option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>