From 897ec3b603ff00b75ccb56c522b46df0ab8eeeb7 Mon Sep 17 00:00:00 2001
From: Mihail Geshoski <mihail@moodle.com>
Date: Sun, 18 Aug 2024 23:15:47 +0800
Subject: [PATCH] MDL-82816 mod_assign: Rename 'View Grader' action button to
 'Grade'

Renames the 'View Grader' action button to 'Grade' and deprecates
the 'viewgrader' string which is no longer used.
---
 mod/assign/lang/en/assign.php                    | 2 +-
 mod/assign/lang/en/deprecated.txt                | 1 +
 mod/assign/templates/grading_actionmenu.mustache | 2 +-
 mod/assign/tests/behat/page_titles.feature       | 2 +-
 4 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/mod/assign/lang/en/assign.php b/mod/assign/lang/en/assign.php
index 84da8a7c86f..d51fe10ac0a 100644
--- a/mod/assign/lang/en/assign.php
+++ b/mod/assign/lang/en/assign.php
@@ -675,7 +675,6 @@ $string['viewfeedback'] = 'View feedback';
 $string['viewfeedbackforuser'] = 'View feedback for user: {$a}';
 $string['viewfullgradingpage'] = 'Open the full grading page to provide feedback';
 $string['viewgradebook'] = 'View gradebook';
-$string['viewgrader'] = 'View Grader';
 $string['viewgradingformforstudent'] = 'View grading page for student: (id={$a->id}, fullname={$a->fullname}).';
 $string['viewgrading'] = 'View all submissions';
 $string['viewownsubmissionform'] = 'View own submit assignment page.';
@@ -694,3 +693,4 @@ $string['attemptreopenmethod_none'] = 'Never';
 $string['choosegradingaction'] = 'Grading action';
 $string['groupoverridesdeleted'] = 'Group overrides deleted';
 $string['useroverridesdeleted'] = 'User overrides deleted';
+$string['viewgrader'] = 'View Grader';
diff --git a/mod/assign/lang/en/deprecated.txt b/mod/assign/lang/en/deprecated.txt
index 66a4ab525d0..a6dfc20f20e 100644
--- a/mod/assign/lang/en/deprecated.txt
+++ b/mod/assign/lang/en/deprecated.txt
@@ -2,3 +2,4 @@ attemptreopenmethod_none,mod_assign
 groupoverridesdeleted,mod_assign
 useroverridesdeleted,mod_assign
 choosegradingaction,mod_assign
+viewgrader,mod_assign
diff --git a/mod/assign/templates/grading_actionmenu.mustache b/mod/assign/templates/grading_actionmenu.mustache
index bafe17b108b..857bdb43884 100644
--- a/mod/assign/templates/grading_actionmenu.mustache
+++ b/mod/assign/templates/grading_actionmenu.mustache
@@ -70,7 +70,7 @@
         {{/pagereset}}
         {{#graderurl}}
         <div class="navitem ms-sm-auto align-self-center">
-            <a class="btn btn-primary" href="{{graderurl}}">{{#str}}viewgrader, mod_assign{{/str}}</a>
+            <a class="btn btn-primary" href="{{graderurl}}">{{#str}}gradeverb, core{{/str}}</a>
         </div>
         {{/graderurl}}
     </div>
diff --git a/mod/assign/tests/behat/page_titles.feature b/mod/assign/tests/behat/page_titles.feature
index 299e56ec0f2..c6ed373ca00 100644
--- a/mod/assign/tests/behat/page_titles.feature
+++ b/mod/assign/tests/behat/page_titles.feature
@@ -30,5 +30,5 @@ Feature: In an assignment, page titles are informative
     Then the page title should contain "C1: History of ants"
     And I follow "View all submissions"
     And the page title should contain "C1: History of ants - Grading"
-    And I click on "Grade" "link" in the "Student 1" "table_row"
+    And I click on "Grade" "link" in the ".tertiary-navigation" "css_element"
     And the page title should contain "C1: History of ants - Grading"