From 7c69ab5dc74002a816393cdcc53402a9be709d4c Mon Sep 17 00:00:00 2001
From: Dan Poltawski <dan@moodle.com>
Date: Tue, 26 Mar 2013 16:27:38 +0800
Subject: [PATCH] MDL-38713 course: correctly set visibleold on mod creation

Remove uncessary set of visibleold in the form
---
 course/modlib.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/course/modlib.php b/course/modlib.php
index 166c63832c7..614ac8aabfb 100644
--- a/course/modlib.php
+++ b/course/modlib.php
@@ -61,6 +61,7 @@ function add_moduleinfo($moduleinfo, $course, $mform = null) {
     $newcm->module           = $moduleinfo->module;
     $newcm->instance         = 0; // Not known yet, will be updated later (this is similar to restore code).
     $newcm->visible          = $moduleinfo->visible;
+    $newcm->visibleold       = $moduleinfo->visible;
     $newcm->groupmode        = $moduleinfo->groupmode;
     $newcm->groupingid       = $moduleinfo->groupingid;
     $newcm->groupmembersonly = $moduleinfo->groupmembersonly;
@@ -128,7 +129,6 @@ function add_moduleinfo($moduleinfo, $course, $mform = null) {
     // Make sure visibility is set correctly (in particular in calendar).
     // Note: allow them to set it even without moodle/course:activityvisibility.
     set_coursemodule_visible($moduleinfo->coursemodule, $moduleinfo->visible);
-    $DB->set_field('course_modules', 'visibleold', 1, array('id' => $moduleinfo->coursemodule));
 
     if (isset($moduleinfo->cmidnumber)) { // Label.
         // Set cm idnumber - uniqueness is already verified by form validation.