L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-75777 phpunit: Move tests to use correct names and ns (take#6)

Browse Source 
Applied the following changes to various testcase classes:

- Namespaced with component[\level2-API]
- Moved to level2-API subdirectory when required.
- Fixed incorrect use statements with leading backslash.
- Remove file phpdoc block
- Remove MOODLE_INTERNAL if not needed.
- Changed code to point to global scope when needed.
- Fix some relative paths and comments here and there.
- All them passing individually.
- Complete runs passing too.
This commit is contained in:
Eloy Lafuente (stronk7)
2022-09-19 11:02:50 +02:00
parent 844abeaf5d
commit be02cc3687
49 changed files with 636 additions and 722 deletions
Download Patch File Download Diff File Expand all files Collapse all files
question/engine/tests/questionattemptiterator_test.php
+12 -17
View File
@@ -14,15 +14,9 @@
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* This file contains tests for the question_attempt_iterator class.
*
* @package moodlecore
* @subpackage questionengine
* @copyright 2009 The Open University
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
namespace core_question;
use question_engine;
defined('MOODLE_INTERNAL') || die();
@@ -30,27 +24,28 @@ global $CFG;
require_once(__DIR__ . '/../lib.php');
require_once(__DIR__ . '/helpers.php');
/**
* This file contains tests for the {@link question_attempt_iterator} class.
*
* @package core_question
* @category test
* @copyright 2009 The Open University
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class question_attempt_iterator_test extends advanced_testcase {
class questionattemptiterator_test extends \advanced_testcase {
private $quba;
private $qas = array();
private $iterator;
protected function setUp(): void {
$this->quba = question_engine::make_questions_usage_by_activity('unit_test',
context_system::instance());
\context_system::instance());
$this->quba->set_preferred_behaviour('deferredfeedback');
$slot = $this->quba->add_question(test_question_maker::make_question('description'));
$slot = $this->quba->add_question(\test_question_maker::make_question('description'));
$this->qas[$slot] = $this->quba->get_question_attempt($slot);
$slot = $this->quba->add_question(test_question_maker::make_question('description'));
$slot = $this->quba->add_question(\test_question_maker::make_question('description'));
$this->qas[$slot] = $this->quba->get_question_attempt($slot);
$this->iterator = $this->quba->get_attempt_iterator();
@@ -88,7 +83,7 @@ class question_attempt_iterator_test extends advanced_testcase {
}
public function test_offsetGet_before_start() {
$this->expectException(moodle_exception::class);
$this->expectException(\moodle_exception::class);
$step = $this->iterator[0];
}
@@ -101,17 +96,17 @@ class question_attempt_iterator_test extends advanced_testcase {
}
public function test_offsetGet_past_end() {
$this->expectException(moodle_exception::class);
$this->expectException(\moodle_exception::class);
$step = $this->iterator[3];
}
public function test_cannot_set() {
$this->expectException(moodle_exception::class);
$this->expectException(\moodle_exception::class);
$this->iterator[0] = null;
}
public function test_cannot_unset() {
$this->expectException(moodle_exception::class);
$this->expectException(\moodle_exception::class);
unset($this->iterator[2]);
}
}