diff --git a/contentbank/classes/content.php b/contentbank/classes/content.php index d9ba6688cb8..f1e84b78e35 100644 --- a/contentbank/classes/content.php +++ b/contentbank/classes/content.php @@ -151,7 +151,7 @@ abstract class content { */ public function set_name(string $name): bool { $name = trim($name); - if (empty($name)) { + if ($name === '') { return false; } diff --git a/contentbank/classes/external/rename_content.php b/contentbank/classes/external/rename_content.php index 2540a8a54fc..48c270f588d 100644 --- a/contentbank/classes/external/rename_content.php +++ b/contentbank/classes/external/rename_content.php @@ -79,7 +79,7 @@ class rename_content extends external_api { $params['name'] = clean_param($params['name'], PARAM_TEXT); // If name is empty don't try to rename and return a more detailed message. - if (empty(trim($params['name']))) { + if (trim($params['name']) === '') { $warnings[] = [ 'item' => $params['contentid'], 'warningcode' => 'emptynamenotallowed', diff --git a/contentbank/tests/contenttype_test.php b/contentbank/tests/contenttype_test.php index 09c0a39565a..d3894ff21e7 100644 --- a/contentbank/tests/contenttype_test.php +++ b/contentbank/tests/contenttype_test.php @@ -464,6 +464,7 @@ class core_contenttype_contenttype_testcase extends \advanced_testcase { 'Too long name' => [str_repeat('a', 300), str_repeat('a', 255), true], 'Empty name' => ['', 'Test content ', false], 'Blanks only' => [' ', 'Test content ', false], + 'Zero name' => ['0', '0', true], ]; } diff --git a/contentbank/tests/external/rename_content_test.php b/contentbank/tests/external/rename_content_test.php index d369bb2bd9e..889baf7ee7e 100644 --- a/contentbank/tests/external/rename_content_test.php +++ b/contentbank/tests/external/rename_content_test.php @@ -60,6 +60,7 @@ class rename_content_testcase extends \externallib_advanced_testcase { 'Too long name' => [str_repeat('a', 300), str_repeat('a', 255), true], 'Empty name' => ['', 'Test content ', false], 'Blanks only' => [' ', 'Test content ', false], + 'Zero name' => ['0', '0', true], ]; }