From 0b2032cb1ee091c004ac989a5ce51f62728e4c16 Mon Sep 17 00:00:00 2001
From: Jun Pataleta <jun@moodle.com>
Date: Wed, 25 Aug 2021 13:04:54 +0800
Subject: [PATCH] MDL-72412 core: Add the image role to informative icon fonts

---
 admin/tool/brickfield/tests/printable_test.php | 2 +-
 lib/templates/pix_icon_fontawesome.mustache    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/admin/tool/brickfield/tests/printable_test.php b/admin/tool/brickfield/tests/printable_test.php
index 1092033fa93..ca8300b7cc0 100644
--- a/admin/tool/brickfield/tests/printable_test.php
+++ b/admin/tool/brickfield/tests/printable_test.php
@@ -101,6 +101,6 @@ class printable_test extends \advanced_testcase {
         $object->set_filter($filter);
         $output = $object->get_output();
         $this->assertStringContainsString('<i class="icon fa fa-tachometer fa-fw "  title="Total activities" '.
-            'aria-label="Total activities">', $output);
+            'role="img" aria-label="Total activities">', $output);
     }
 }
diff --git a/lib/templates/pix_icon_fontawesome.mustache b/lib/templates/pix_icon_fontawesome.mustache
index 34e74bda01d..778584e3017 100644
--- a/lib/templates/pix_icon_fontawesome.mustache
+++ b/lib/templates/pix_icon_fontawesome.mustache
@@ -43,7 +43,7 @@
 
 }}
 {{^unmappedIcon}}
-<i class="icon fa {{key}} fa-fw {{extraclasses}}" {{#aria-hidden}}aria-hidden="true"{{/aria-hidden}} {{#title}}title="{{title}}"{{/title}} {{#alt}}aria-label="{{alt}}"{{/alt}}></i>
+<i class="icon fa {{key}} fa-fw {{extraclasses}}" {{#aria-hidden}}aria-hidden="true"{{/aria-hidden}} {{#title}}title="{{title}}"{{/title}} {{#alt}}role="img" aria-label="{{alt}}"{{/alt}}></i>
 {{/unmappedIcon}}
 {{#unmappedIcon}}
 {{! We cannot include the pix_icon template directly here because we don't have all the mustache helpers loaded. }}