MDL-83468 phpunit: Fix various tests after phpunit 10

lib/phpunit/classes/basic_testcase.php

@@ -1,4 +1,5 @@
 <?php
+use PHPUnit\Framework\Attributes\After;
 // This file is part of Moodle - http://moodle.org/
 //
 // Moodle is free software: you can redistribute it and/or modify
@@ -14,16 +15,6 @@
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
-/**
- * Basic test case.
- *
- * @package    core
- * @category   phpunit
- * @copyright  2012 Petr Skoda {@link http://skodak.org}
- * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-
-
 /**
  * The simplest PHPUnit test case customised for Moodle
  *
@@ -35,50 +26,26 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 abstract class basic_testcase extends base_testcase {
-
     /**
      * Constructs a test case with the given name.
      *
-     * Note: use setUp() or setUpBeforeClass() in your test cases.
      *
      * @param string $name
-     * @param array  $data
-     * @param string $dataName
      */
-    final public function __construct($name = null, array $data = array(), $dataName = '') {
-        parent::__construct($name, $data, $dataName);
+    final public function __construct($name = null) {
+        parent::__construct($name);
 
         $this->setBackupGlobals(false);
-        $this->setBackupStaticAttributes(false);
         $this->setRunTestInSeparateProcess(false);
     }
 
-    /**
-     * Runs the bare test sequence and log any changes in global state or database.
-     * @return void
-     */
-    final public function runBare(): void {
+    #[After]
+    final public function test_teardown(): void {
         global $DB;
 
-        try {
-            parent::runBare();
-
-        } catch (Exception $ex) {
-            $e = $ex;
-        } catch (Throwable $ex) {
-            // Engine errors in PHP7 throw exceptions of type Throwable (this "catch" will be ignored in PHP5).
-            $e = $ex;
-        }
-
-        if (isset($e)) {
-            // cleanup after failed expectation
-            phpunit_util::reset_all_data();
-            throw $e;
-        }
-
         if ($DB->is_transaction_started()) {
             phpunit_util::reset_all_data();
-            throw new coding_exception('basic_testcase '.$this->getName().' is not supposed to use database transactions!');
+            throw new coding_exception('basic_testcase ' . $this->getName() . ' is not supposed to use database transactions!');
         }
 
         phpunit_util::reset_all_data(true);