L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-29332 question: calculated variables may differ in case only

Browse Source
This commit is contained in:
Marina Glancy
2016-09-13 10:15:26 +08:00
parent b022c2cd1c
commit bc48debf36
5 changed files with 37 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
question/engine/datalib.php
+12 -3
View File
@@ -287,10 +287,19 @@ class question_engine_data_mapper {
*/
public function update_question_attempt_metadata(question_attempt $qa, array $names) {
global $DB;
list($condition, $params) = $DB->get_in_or_equal($names);
$params[] = $qa->get_step(0)->get_id();
if (!$names) {
return [];
}
// Use case-sensitive LIKE instead of get_in_or_equal.
// Some databases may use case-insensitive collation, we don't want to delete 'X' instead of 'x'.
$sqls = [];
$params = [$qa->get_step(0)->get_id()];
foreach ($names as $name) {
$sqls[] = $DB->sql_like('name', '?', true);
$params[] = $DB->sql_like_escape($name);
}
$DB->delete_records_select('question_attempt_step_data',
'name ' . $condition . ' AND attemptstepid = ?', $params);
'attemptstepid = ? AND (' . join(' OR ', $sqls) . ')', $params);
return $this->insert_question_attempt_metadata($qa, $names);
}