L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-54542 competency: Prevent long query aliases in get_sql_fields()

Browse Source 
Otherwise we could hit ORA-00972 because they exceed 30 characters.
This commit is contained in:
Frederic Massart
2016-05-12 16:14:32 +08:00
parent 1e72daa899
commit bbf727f175
3 changed files with 46 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
competency/tests/persistent_test.php
+29
View File
@@ -392,6 +392,35 @@ class core_competency_persistent_testcase extends advanced_testcase {
$this->assertFalse(core_competency_testable_persistent::record_exists($id));
}
public function test_get_sql_fields() {
$expected = '' .
'c.id AS comp_id, ' .
'c.shortname AS comp_shortname, ' .
'c.idnumber AS comp_idnumber, ' .
'c.description AS comp_description, ' .
'c.descriptionformat AS comp_descriptionformat, ' .
'c.parentid AS comp_parentid, ' .
'c.path AS comp_path, ' .
'c.sortorder AS comp_sortorder, ' .
'c.competencyframeworkid AS comp_competencyframeworkid, ' .
'c.ruletype AS comp_ruletype, ' .
'c.ruleconfig AS comp_ruleconfig, ' .
'c.ruleoutcome AS comp_ruleoutcome, ' .
'c.scaleid AS comp_scaleid, ' .
'c.scaleconfiguration AS comp_scaleconfiguration, ' .
'c.timecreated AS comp_timecreated, ' .
'c.timemodified AS comp_timemodified, ' .
'c.usermodified AS comp_usermodified';
$this->assertEquals($expected, core_competency_testable_persistent::get_sql_fields('c', 'comp_'));
}
/**
* @expectedException coding_exception
* @expectedExceptionMessageRegExp /The alias .+ exceeds 30 characters/
*/
public function test_get_sql_fields_too_long() {
core_competency_testable_persistent::get_sql_fields('c');
}
}
/**