From e882740a56595713e2339877c9021226d51d4464 Mon Sep 17 00:00:00 2001 From: "Eloy Lafuente (stronk7)" Date: Thu, 1 Nov 2018 00:24:54 +0100 Subject: [PATCH] MDL-63826 tests: Don't rely on random array keys for testing --- mod/assign/submission/comments/tests/privacy_test.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/mod/assign/submission/comments/tests/privacy_test.php b/mod/assign/submission/comments/tests/privacy_test.php index c02e7959abf..e30e7ee2c80 100644 --- a/mod/assign/submission/comments/tests/privacy_test.php +++ b/mod/assign/submission/comments/tests/privacy_test.php @@ -174,9 +174,11 @@ class assignsubmission_comments_privacy_testcase extends \mod_assign\tests\mod_a \assignsubmission_comments\privacy\provider::get_userids_from_context($userlist); $userids = $userlist->get_userids(); $this->assertCount(3, $userids); - // Two is the key for user 3. - $this->assertEquals(2, array_search($user3->id, $userids)); - $this->assertFalse(array_search($user4->id, $userids)); + // User 1,2 and 3 are the expected ones in the array. User 4 isn't. + $this->assertContains($user1->id, $userids); + $this->assertContains($user2->id, $userids); + $this->assertContains($user3->id, $userids); + $this->assertNotContains($user4->id, $userids); } /**