From bb790b84ca9d3cb8fbf6ec96b85cdb655a32059c Mon Sep 17 00:00:00 2001 From: Tony Butler Date: Tue, 17 Feb 2015 14:56:38 +0000 Subject: [PATCH] MDL-49075 mod_assign: Keep unreleased assign grades out of gradebook --- mod/assign/locallib.php | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/mod/assign/locallib.php b/mod/assign/locallib.php index c2274395949..3d6b4a5c737 100644 --- a/mod/assign/locallib.php +++ b/mod/assign/locallib.php @@ -7095,16 +7095,19 @@ class assign { $where, $params); foreach ($graderesults as $result) { - $gradebookgrade = clone $result; - // Now get the feedback. - if ($gradebookplugin) { - $grade = $this->get_user_grade($result->userid, false); - if ($grade) { - $gradebookgrade->feedback = $gradebookplugin->text_for_gradebook($grade); - $gradebookgrade->feedbackformat = $gradebookplugin->format_for_gradebook($grade); + $gradingstatus = $this->get_grading_status($result->userid); + if (!$this->get_instance()->markingworkflow || $gradingstatus == ASSIGN_MARKING_WORKFLOW_STATE_RELEASED) { + $gradebookgrade = clone $result; + // Now get the feedback. + if ($gradebookplugin) { + $grade = $this->get_user_grade($result->userid, false); + if ($grade) { + $gradebookgrade->feedback = $gradebookplugin->text_for_gradebook($grade); + $gradebookgrade->feedbackformat = $gradebookplugin->format_for_gradebook($grade); + } } + $grades[$gradebookgrade->userid] = $gradebookgrade; } - $grades[$gradebookgrade->userid] = $gradebookgrade; } $graderesults->close();