From bb53eb49a8dd3170f3d560057647e033efe30ff3 Mon Sep 17 00:00:00 2001
From: iarenaza <iarenaza>
Date: Fri, 26 Dec 2008 15:57:55 +0000
Subject: [PATCH] auth/ldap: MDL-9405 sync_users() can create duplicated users

If we are using auth_ldap_sync_users.php to synchronize our users, and we
have a database which is case-sensitive when doing comparisons (Postgres and
Oracle at least), and any of our users has the vale of the username attribute
in mixed-case (like 'John Smith'), we get duplicated users.

This is because we don't make sure the username attribute value is 'lowercased'
after we retrive it from the LDAP server and before we insert it into the
database.
---
 auth/ldap/auth.php | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/auth/ldap/auth.php b/auth/ldap/auth.php
index 5df01079c91..2ed1a02544c 100644
--- a/auth/ldap/auth.php
+++ b/auth/ldap/auth.php
@@ -671,6 +671,9 @@ class auth_plugin_ldap extends auth_plugin_base {
                 $user->confirmed  = 1;
                 $user->auth       = 'ldap';
                 $user->mnethostid = $CFG->mnet_localhost_id;
+                // get_userinfo_asobj() might have replaced $user->username with the value
+                // from the LDAP server (which can be mixed-case). Make sure it's lowercase
+                $user->username = trim(moodle_strtolower($user->username));
                 if (empty($user->lang)) {
                     $user->lang = $CFG->lang;
                 }