MDL-65292 style: Fix all function declarations white space

This has been generated running the following Sniffs, all
them part of the Moodle's CodeSniffer standard:
- PSR12.Functions.ReturnTypeDeclaration
- PSR12.Functions.NullableTypeDeclaration
- moodle.Methods.MethodDeclarationSpacing
- Squiz.Whitespace.ScopeKeywordSpacing

All them are, exclusively, about correct spacing, so the changes
are, all them, only white space changes.

Only exceptions to the above are 3 changes what were setting the
return type in a new line, and, when that happens, the closing
parenthesis (bracket) has to go to the same line than the colon.

lib/classes/analytics/indicator/any_access_after_end.php

@@ -42,7 +42,7 @@ class any_access_after_end extends \core_analytics\local\indicator\binary {
      *
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('indicator:accessesafterend');
     }
 

lib/classes/analytics/indicator/any_access_before_start.php

@@ -42,7 +42,7 @@ class any_access_before_start extends \core_analytics\local\indicator\binary {
      *
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('indicator:accessesbeforestart');
     }
 

lib/classes/analytics/indicator/any_course_access.php

@@ -45,7 +45,7 @@ class any_course_access extends \core_analytics\local\indicator\binary {
      *
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('indicator:anycourseaccess');
     }
 

lib/classes/analytics/indicator/any_write_action.php

@@ -42,7 +42,7 @@ class any_write_action extends \core_analytics\local\indicator\binary {
      *
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('indicator:anywrite');
     }
 

lib/classes/analytics/indicator/any_write_action_in_course.php

@@ -42,7 +42,7 @@ class any_write_action_in_course extends \core_analytics\local\indicator\binary
      *
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('indicator:anywriteincourse');
     }
 

lib/classes/analytics/indicator/read_actions.php

@@ -42,7 +42,7 @@ class read_actions extends \core_analytics\local\indicator\linear {
      *
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('indicator:readactions');
     }
 

lib/classes/analytics/time_splitting/deciles.php

@@ -44,7 +44,7 @@ class deciles extends \core_analytics\local\time_splitting\equal_parts {
      *
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('timesplitting:deciles');
     }
 

lib/classes/analytics/time_splitting/deciles_accum.php

@@ -44,7 +44,7 @@ class deciles_accum extends \core_analytics\local\time_splitting\accumulative_pa
      *
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('timesplitting:decilesaccum');
     }
 

lib/classes/analytics/time_splitting/no_splitting.php

@@ -48,7 +48,7 @@ class no_splitting extends \core_analytics\local\time_splitting\base {
      *
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('timesplitting:nosplitting');
     }
 

lib/classes/analytics/time_splitting/one_month_after_start.php

@@ -40,7 +40,7 @@ class one_month_after_start extends \core_analytics\local\time_splitting\after_s
      *
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('timesplitting:onemonthafterstart');
     }
 

lib/classes/analytics/time_splitting/one_week_after_start.php

@@ -40,7 +40,7 @@ class one_week_after_start extends \core_analytics\local\time_splitting\after_st
      *
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('timesplitting:oneweekafterstart');
     }
 

lib/classes/analytics/time_splitting/past_3_days.php

@@ -40,7 +40,7 @@ class past_3_days extends \core_analytics\local\time_splitting\past_periodic {
      *
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('timesplitting:past3days');
     }
 

lib/classes/analytics/time_splitting/past_month.php

@@ -40,7 +40,7 @@ class past_month extends \core_analytics\local\time_splitting\past_periodic {
      *
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('timesplitting:pastmonth');
     }
 

lib/classes/analytics/time_splitting/past_week.php

@@ -39,7 +39,7 @@ class past_week extends \core_analytics\local\time_splitting\past_periodic {
      * The time splitting method name.
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('timesplitting:pastweek');
     }
 

lib/classes/analytics/time_splitting/quarters.php

@@ -44,7 +44,7 @@ class quarters extends \core_analytics\local\time_splitting\equal_parts {
      *
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('timesplitting:quarters');
     }
 

lib/classes/analytics/time_splitting/quarters_accum.php

@@ -44,7 +44,7 @@ class quarters_accum extends \core_analytics\local\time_splitting\accumulative_p
      *
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('timesplitting:quartersaccum');
     }
 

lib/classes/analytics/time_splitting/single_range.php

@@ -45,7 +45,7 @@ class single_range extends \core_analytics\local\time_splitting\base
      *
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('timesplitting:singlerange');
     }
 

lib/classes/analytics/time_splitting/ten_percent_after_start.php

@@ -40,7 +40,7 @@ class ten_percent_after_start extends \core_analytics\local\time_splitting\after
      *
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('timesplitting:tenpercentafterstart');
     }
 

lib/classes/analytics/time_splitting/upcoming_3_days.php

@@ -39,7 +39,7 @@ class upcoming_3_days extends \core_analytics\local\time_splitting\upcoming_peri
      * The time splitting method name.
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('timesplitting:upcoming3days');
     }
 

lib/classes/analytics/time_splitting/upcoming_fortnight.php

@@ -39,7 +39,7 @@ class upcoming_fortnight extends \core_analytics\local\time_splitting\upcoming_p
      * The time splitting method name.
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('timesplitting:upcomingfortnight');
     }
 

lib/classes/analytics/time_splitting/upcoming_week.php

@@ -39,7 +39,7 @@ class upcoming_week extends \core_analytics\local\time_splitting\upcoming_period
      * The time splitting method name.
      * @return \lang_string
      */
-    public static function get_name() : \lang_string {
+    public static function get_name(): \lang_string {
         return new \lang_string('timesplitting:upcomingweek');
     }