From ba131ff29d51961a02b5c0e920bc2e13d474b671 Mon Sep 17 00:00:00 2001
From: David Carrillo <davidmc@moodle.com>
Date: Tue, 17 Sep 2024 16:32:30 +0200
Subject: [PATCH] MDL-83179 badges: Get type and courseid from context instead
 of params

---
 .../local/systemreports/course_badges.php       | 17 +++++++++++++----
 badges/view.php                                 |  3 +--
 2 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/badges/classes/reportbuilder/local/systemreports/course_badges.php b/badges/classes/reportbuilder/local/systemreports/course_badges.php
index f415e287b66..6c56c789379 100644
--- a/badges/classes/reportbuilder/local/systemreports/course_badges.php
+++ b/badges/classes/reportbuilder/local/systemreports/course_badges.php
@@ -18,8 +18,10 @@ declare(strict_types=1);
 
 namespace core_badges\reportbuilder\local\systemreports;
 
+use core\context\system;
 use core_badges\reportbuilder\local\entities\badge;
 use core_badges\reportbuilder\local\entities\badge_issued;
+use core_reportbuilder\local\helpers\database;
 use core_reportbuilder\system_report;
 use lang_string;
 use moodle_url;
@@ -52,11 +54,18 @@ class course_badges extends system_report {
         $this->set_main_table('badge', $entityalias);
         $this->add_entity($badgeentity);
 
-        $type = $this->get_parameter('type', 0, PARAM_INT);
-        $courseid = $this->get_parameter('courseid', 0, PARAM_INT);
+        $paramtype = database::generate_param_name();
+        $context = $this->get_context();
+        if ($context instanceof system) {
+            $type = BADGE_TYPE_SITE;
+            $this->add_base_condition_sql("{$entityalias}.type = :$paramtype", [$paramtype => $type]);
+        } else {
+            $type = BADGE_TYPE_COURSE;
+            $paramcourseid = database::generate_param_name();
+            $this->add_base_condition_sql("{$entityalias}.type = :$paramtype AND {$entityalias}.courseid = :$paramcourseid",
+                [$paramtype => $type, $paramcourseid => $context->instanceid]);
+        }
 
-        $this->add_base_condition_simple('type', $type);
-        $this->add_base_condition_simple('courseid', $courseid);
         $this->add_base_condition_sql("({$entityalias}.status = " . BADGE_STATUS_ACTIVE .
             " OR {$entityalias}.status = " . BADGE_STATUS_ACTIVE_LOCKED . ")");
 
diff --git a/badges/view.php b/badges/view.php
index 9ce804abdcf..7582384d971 100644
--- a/badges/view.php
+++ b/badges/view.php
@@ -103,8 +103,7 @@ if ($course && $course->startdate > time()) {
     echo $OUTPUT->box(get_string('error:notifycoursedate', 'badges'), 'generalbox notifyproblem');
 }
 
-$report = system_report_factory::create(course_badges::class, $PAGE->context, '', '', 0,
-    ['type' => $type, 'courseid' => $courseid]);
+$report = system_report_factory::create(course_badges::class, $PAGE->context);
 echo $report->output();
 
 // Trigger event, badge listing viewed.