From ba0a68e254f6c14acbf7fafda7ee79ad913ea91d Mon Sep 17 00:00:00 2001 From: David Monllao Date: Wed, 4 Jul 2018 16:09:46 +0200 Subject: [PATCH] MDL-60520 analytics: Set predictor at model level during testing --- analytics/tests/prediction_test.php | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/analytics/tests/prediction_test.php b/analytics/tests/prediction_test.php index 39c2b98a167..34d82f7ab3d 100644 --- a/analytics/tests/prediction_test.php +++ b/analytics/tests/prediction_test.php @@ -143,10 +143,8 @@ class core_analytics_prediction_testcase extends advanced_testcase { $this->markTestSkipped('Skipping ' . $predictionsprocessorclass . ' as the predictor is not ready.'); } - set_config('predictionsprocessor', $predictionsprocessorclass, 'analytics'); - $model = $this->add_perfect_model(); - $model->enable($timesplittingid); + $model->update(true, false, $timesplittingid, get_class($predictionsprocessor)); // No samples trained yet. $this->assertEquals(0, $DB->count_records('analytics_train_samples', array('modelid' => $model->get_id()))); @@ -423,8 +421,7 @@ class core_analytics_prediction_testcase extends advanced_testcase { $this->markTestSkipped('Skipping ' . $predictionsprocessorclass . ' as the predictor is not ready.'); } - set_config('predictionsprocessor', $predictionsprocessorclass, 'analytics'); - + $model->update(false, false, false, get_class($predictionsprocessor)); $results = $model->evaluate(); // We check that the returned status includes at least $expectedcode code.