diff --git a/mod/scorm/api1_2.php b/mod/scorm/api1_2.php
index 360e981a6c3..f10e3085910 100644
--- a/mod/scorm/api1_2.php
+++ b/mod/scorm/api1_2.php
@@ -177,8 +177,8 @@ function SCORMapi() {
return "false";
}
if (Initialized) {
- if (top.nav.cmi.document.theform) {
- cmiform = top.nav.cmi.document.forms[0];
+ if (cmi.document.theform) {
+ cmiform = cmi.document.forms[0];
cmiform.scoid.value = "id; ?>";
cmiform.cmi_core_lesson_location.value = cmi.core.lesson_location;
cmiform.cmi_core_lesson_status.value = cmi.core.lesson_status;
@@ -211,7 +211,7 @@ function SCORMapi() {
auto) {
if ($sco != $last) {
- print "setTimeout('top.nav.document.navform.next.click();',500);\n";
+ print "setTimeout('".$navObj."document.navform.next.click();',500);\n";
} else {
print "exitloc = '".$CFG->wwwroot."/mod/scorm/view.php?id=$cm->id';\n";
print "setTimeout('top.location = exitloc;',500);\n";
diff --git a/mod/scorm/details.php b/mod/scorm/details.php
index f2bc1f59c5f..9d29190be04 100755
--- a/mod/scorm/details.php
+++ b/mod/scorm/details.php
@@ -88,7 +88,7 @@
}
echo "
setnewwindow)) {
- $optionlist = array();
- foreach ($SCORM_WINDOW_OPTIONS as $option) {
- if (isset($scorm->$option)) {
- $optionlist[] = $option."=".$scorm->$option;
- }
+ $scorm->popup = "";
+
+ $optionlist = array();
+ foreach ($SCORM_WINDOW_OPTIONS as $option) {
+ if (isset($scorm->$option)) {
+ $optionlist[] = $option."=".$scorm->$option;
}
- $scorm->popup = implode(',', $optionlist);
- $scorm->popup .= ',location=0,menubar=0,toolbar=0';
- $scorm->auto = '0';
}
+ $scorm->popup = implode(',', $optionlist);
+ $scorm->auto = '0';
+
+ if ($scorm->popup != "")
+ $scorm->popup .= ',location=0,menubar=0,toolbar=0';
return insert_record("scorm", $scorm);
}
@@ -64,17 +66,19 @@ function scorm_update_instance($scorm) {
# May have to add extra stuff in here #
global $SCORM_WINDOW_OPTIONS;
- if (isset($scorm->setnewwindow)) {
- $optionlist = array();
- foreach ($SCORM_WINDOW_OPTIONS as $option) {
- if (isset($scorm->$option)) {
- $optionlist[] = $option."=".$scorm->$option;
- }
+ $scorm->popup = "";
+
+ $optionlist = array();
+ foreach ($SCORM_WINDOW_OPTIONS as $option) {
+ if (isset($scorm->$option)) {
+ $optionlist[] = $option."=".$scorm->$option;
}
- $scorm->popup = implode(',', $optionlist);
- $scorm->popup .= ',location=0,menubar=0,toolbar=0';
- $scorm->auto = '0';
}
+ $scorm->popup = implode(',', $optionlist);
+ $scorm->auto = '0';
+
+ if ($scorm->popup != "")
+ $scorm->popup .= ',location=0,menubar=0,toolbar=0';
return update_record("scorm", $scorm);
}
diff --git a/mod/scorm/mod.html b/mod/scorm/mod.html
index b6f874d8f61..0d9f1c9bf97 100755
--- a/mod/scorm/mod.html
+++ b/mod/scorm/mod.html
@@ -60,6 +60,7 @@
+
diff --git a/mod/scorm/playscorm.php b/mod/scorm/playscorm.php
index 8f7862a32ef..f0d29bbd054 100755
--- a/mod/scorm/playscorm.php
+++ b/mod/scorm/playscorm.php
@@ -55,7 +55,15 @@
update_module_button($cm->id, $course->id, $strscorm), navmenu($course, $cm));
notice(get_string("activityiscurrentlyhidden"));
}
- if ($frameset == "top") {
+
+ if (!empty($_POST["scoid"]))
+ $scoid = "&scoid=".$_POST["scoid"];
+ if (($scorm->popup != "") && (!empty($_POST["mode"])))
+ $mode = $_POST["mode"];
+ if (($scorm->popup == "") && (!empty($_GET["mode"])))
+ $mode = $_GET["mode"];
+
+ if (($frameset == "top") || ($scorm->popup != "")) {
add_to_log($course->id, "scorm", "view", "playscorm.php?id=$cm->id", "$scorm->id");
//
// Print the page header
@@ -65,51 +73,15 @@
"", "", true, update_module_button($cm->id, $course->id, $strscorm), navmenu($course, $cm, '_top'));
echo "\n | ".text_to_html($scorm->summary, true, false)." | \n";
- if ($_GET["mode"] == "browse")
+ if ($mode == "browse")
echo "".get_string("browsemode","scorm")." | \n";
echo "
\n
\n";
-
-
- echo "\n \n";
- echo " |
-
-
- | \n";
-
- echo "
\n
\n";
- if ($scorm->popup != "") {
+ if ($scorm->popup != "") {
+ echo "\n";
$currentSCO = "";
- if (!empty($_GET['scoid']))
- $currentSCO = $_GET['scoid'];
+ if (!empty($_POST['scoid']))
+ $currentSCO = $_POST['scoid'];
?>
+ \n