L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-12523 accesslib: get_user_by_capability() - Simple cases now handle multiple RAs

Browse Source 
The "simple" case SQL did not handle multiple enrolments for the same
user correctly -- it would generate multiple rows for those users,
incorrectly.

With this patch we move the join to RA to a subselect where DISTINCT
takes care of things.

MDL-12452
This commit is contained in:
martinlanghoff
2008-01-06 23:16:20 +00:00
parent 6d5d43bab3
commit b8dc2b75a4
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/accesslib.php
+10 -5
View File
@@ -4325,14 +4325,19 @@ function get_users_by_capability($context, $capability, $fields='', $sort='',
return get_records_sql($sql, $limitfrom, $limitnum);
}
/// Simple SQL assuming no negative rolecaps
/// Simple SQL assuming no negative rolecaps.
/// We use a subselect to grab the role assignments
/// ensuring only one row per user -- even if they
/// have many "relevant" role assignments.
$select = " SELECT $fields";
$from = " FROM {$CFG->prefix}user u
JOIN {$CFG->prefix}role_assignments ra ON ra.userid = u.id
JOIN (SELECT DISTINCT ssra.userid
FROM {$CFG->prefix}role_assignments ssra
WHERE ssra.contextid IN ($ctxids)
AND ssra.roleid IN (".implode(',',$roleids) .")
) ra ON ra.userid = u.id
$uljoin ";
$where = " WHERE ra.contextid IN ($ctxids)
AND u.deleted = 0
AND ra.roleid IN (".implode(',',$roleids) .")";
$where = " WHERE u.deleted = 0 ";
if (count(array_keys($wherecond))) {
$where .= ' AND ' . implode(' AND ', array_values($wherecond));
}