diff --git a/lib/adodb/drivers/adodb-mssql.inc.php b/lib/adodb/drivers/adodb-mssql.inc.php index 068dffce0d9..3e6de38f7cf 100644 --- a/lib/adodb/drivers/adodb-mssql.inc.php +++ b/lib/adodb/drivers/adodb-mssql.inc.php @@ -680,7 +680,9 @@ order by constraint_name, referenced_table_name, keyno"; $arr = $args; } - array_walk($arr, create_function('&$v', '$v = "CAST(" . $v . " AS VARCHAR(255))";')); + array_walk($arr, function(&$v) { + $v = "CAST(" . $v . " AS VARCHAR(255))"; + }); $s = implode('+',$arr); if (sizeof($arr) > 0) return "$s"; diff --git a/lib/adodb/drivers/adodb-mssqlnative.inc.php b/lib/adodb/drivers/adodb-mssqlnative.inc.php index 23eb2c03d4c..e70219b1977 100644 --- a/lib/adodb/drivers/adodb-mssqlnative.inc.php +++ b/lib/adodb/drivers/adodb-mssqlnative.inc.php @@ -527,7 +527,9 @@ class ADODB_mssqlnative extends ADOConnection { $arr = $args; } - array_walk($arr, create_function('&$v', '$v = "CAST(" . $v . " AS VARCHAR(255))";')); + array_walk($arr, function(&$v) { + $v = "CAST(" . $v . " AS VARCHAR(255))"; + }); $s = implode('+',$arr); if (sizeof($arr) > 0) return "$s"; diff --git a/lib/adodb/drivers/adodb-text.inc.php b/lib/adodb/drivers/adodb-text.inc.php index 8844d20e14f..56a52393401 100644 --- a/lib/adodb/drivers/adodb-text.inc.php +++ b/lib/adodb/drivers/adodb-text.inc.php @@ -260,7 +260,7 @@ class ADODB_text extends ADOConnection { $projnames = array($n); reset($where_arr); - while (list($k_a,$a) = each($where_arr)) { + foreach ($where_arr as $k_a => $a) { if ($i == 0 && $this->_skiprow1) { $projarray[] = array($n); continue; diff --git a/lib/adodb/readme_moodle.txt b/lib/adodb/readme_moodle.txt index 00ff24052c0..479cb790a85 100644 --- a/lib/adodb/readme_moodle.txt +++ b/lib/adodb/readme_moodle.txt @@ -32,5 +32,6 @@ Our changes: Check if fixed upstream during the next upgrade and remove this note. (8638b3f1441d4b928) * MDL-58546 replaced each() with foreach for PHP 7.2 compatibility. pull request upstream: https://github.com/ADOdb/ADOdb/pull/373 + * MDL-65920 solved PHP 7.2 deprecations; create_function() and each(). skodak, iarenaza, moodler, stronk7, abgreeve, lameze, ankitagarwal, marinaglancy