From b8602beb62981ede081442e5595d6044ab7ba877 Mon Sep 17 00:00:00 2001
From: Simey Lameze <simey@moodle.com>
Date: Fri, 17 Jun 2022 09:50:38 +0800
Subject: [PATCH] MDL-72292 core: add param type and polishing

---
 lib/classes/component.php | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/lib/classes/component.php b/lib/classes/component.php
index 6880ea9c7c2..dece4396550 100644
--- a/lib/classes/component.php
+++ b/lib/classes/component.php
@@ -1203,18 +1203,20 @@ $cache = '.var_export($cache, true).';
      * and the value is the new class name.
      * It is only included when we are populating the component cache. After that is not needed.
      *
-     * @param string $fulldir
+     * @param string|null $fulldir The directory to the renamed classes.
      */
-    protected static function load_renamed_classes($fulldir) {
-        if (isset($fulldir)) {
-            $file = $fulldir . '/db/renamedclasses.php';
-            if (is_readable($file)) {
-                $renamedclasses = null;
-                require($file);
-                if (is_array($renamedclasses)) {
-                    foreach ($renamedclasses as $oldclass => $newclass) {
-                        self::$classmaprenames[(string)$oldclass] = (string)$newclass;
-                    }
+    protected static function load_renamed_classes(?string $fulldir) {
+        if (is_null($fulldir)) {
+            return;
+        }
+
+        $file = $fulldir . '/db/renamedclasses.php';
+        if (is_readable($file)) {
+            $renamedclasses = null;
+            require($file);
+            if (is_array($renamedclasses)) {
+                foreach ($renamedclasses as $oldclass => $newclass) {
+                    self::$classmaprenames[(string)$oldclass] = (string)$newclass;
                 }
             }
         }