From 42ef700aff2cb182521a44335712b5dff17b7be2 Mon Sep 17 00:00:00 2001
From: Stephan Robotta <stephan.robotta@bfh.ch>
Date: Thu, 5 Oct 2023 09:37:52 +0200
Subject: [PATCH] MDL-79604 mod_data: exception if mandatory checkox list is
 missing

---
 mod/data/field/checkbox/field.class.php | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/mod/data/field/checkbox/field.class.php b/mod/data/field/checkbox/field.class.php
index 25f0d5d24cd..3f47aa316ba 100644
--- a/mod/data/field/checkbox/field.class.php
+++ b/mod/data/field/checkbox/field.class.php
@@ -53,18 +53,16 @@ class data_field_checkbox extends data_field_base {
     }
 
     function display_add_field($recordid = 0, $formdata = null) {
-        global $CFG, $DB, $OUTPUT;
-
-        $content = array();
+        global $DB, $OUTPUT;
 
         if ($formdata) {
             $fieldname = 'field_' . $this->field->id;
-            $content = $formdata->$fieldname;
+            $content = $formdata->$fieldname ?? [];
         } else if ($recordid) {
-            $content = $DB->get_field('data_content', 'content', array('fieldid'=>$this->field->id, 'recordid'=>$recordid));
+            $content = $DB->get_field('data_content', 'content', ['fieldid' => $this->field->id, 'recordid' => $recordid]);
             $content = explode('##', $content);
         } else {
-            $content = array();
+            $content = [];
         }
 
         $str = '<div title="' . s($this->field->description) . '">';