From 09a92706401b778b533c09bcd4dc2a959f88d0a0 Mon Sep 17 00:00:00 2001 From: Tim Lock Date: Thu, 16 Oct 2014 08:34:53 +1030 Subject: [PATCH 1/2] MDL-47700 Grades: Sitewide overview report isn't visible in some cases Showing a overview report rank sitewide isn't visible to student in same cases --- grade/report/overview/settings.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/grade/report/overview/settings.php b/grade/report/overview/settings.php index c1e43d8c622..27bbd7add14 100644 --- a/grade/report/overview/settings.php +++ b/grade/report/overview/settings.php @@ -26,7 +26,8 @@ defined('MOODLE_INTERNAL') || die; if ($ADMIN->fulltree) { - $settings->add(new admin_setting_configcheckbox('grade_report_overview_showrank', get_string('showrank', 'grades'), get_string('showrank_help', 'grades'), 0, PARAM_INT)); + $settings->add(new admin_setting_configcheckbox('grade_report_overview_showrank', get_string('showrank', 'grades'), + get_string('showrank_help', 'grades'), 0)); $settings->add(new admin_setting_configselect('grade_report_overview_showtotalsifcontainhidden', get_string('hidetotalifhiddenitems', 'grades'), get_string('hidetotalifhiddenitems_help', 'grades'), GRADE_REPORT_HIDE_TOTAL_IF_CONTAINS_HIDDEN, From 8bcd9391238b1b6bbfbf93a851f11cfaa3b10be9 Mon Sep 17 00:00:00 2001 From: John Okely Date: Thu, 13 Nov 2014 14:26:31 +0800 Subject: [PATCH 2/2] MDL-47700 Grades: Fix incorrect config for overview report showrank --- grade/report/overview/lib.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grade/report/overview/lib.php b/grade/report/overview/lib.php index 90ca93def3e..c4efb454367 100644 --- a/grade/report/overview/lib.php +++ b/grade/report/overview/lib.php @@ -249,7 +249,7 @@ function grade_report_overview_settings_definition(&$mform) { 0 => get_string('hide'), 1 => get_string('show')); - if (empty($CFG->grade_overviewreport_showrank)) { + if (empty($CFG->grade_report_overview_showrank)) { $options[-1] = get_string('defaultprev', 'grades', $options[0]); } else { $options[-1] = get_string('defaultprev', 'grades', $options[1]);