From 6edfe1b415f63fd21c7c61aee92d8d2a19cd99cf Mon Sep 17 00:00:00 2001
From: Tim Hunt <T.J.Hunt@open.ac.uk>
Date: Thu, 28 Mar 2024 16:55:07 +0000
Subject: [PATCH] MDL-81383 questions: get_filtered_questions order should be
 predictable

This method supports $limit and $offset paramters. The query must have
a predictable ORDER BY for that to make sense.
---
 question/classes/local/bank/random_question_loader.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/question/classes/local/bank/random_question_loader.php b/question/classes/local/bank/random_question_loader.php
index 7daa6993d40..bdc5bd1b9ce 100644
--- a/question/classes/local/bank/random_question_loader.php
+++ b/question/classes/local/bank/random_question_loader.php
@@ -512,7 +512,8 @@ class random_question_loader {
                       FROM {question} q
                       JOIN {question_versions} qv ON qv.questionid = q.id
                       JOIN {question_bank_entries} qbe ON qbe.id = qv.questionbankentryid
-                      {$condition}) q";
+                      {$condition}) q
+                  ORDER BY q.id";
 
             return $DB->get_records_sql($sql, $param, $offset, $limit);
         } else {