From b5e6b1d3a721049ebbfdadc2090b99eca13b9eee Mon Sep 17 00:00:00 2001
From: Paul Holden <paulh@moodle.com>
Date: Thu, 21 Mar 2024 15:55:18 +0000
Subject: [PATCH] MDL-81321 mod_data: deprecate fields page "View template"
 footer.

---
 .upgradenotes/MDL-81321-2024052421223463.yml | 7 +++++++
 mod/data/field.php                           | 3 ---
 mod/data/renderer.php                        | 5 +++++
 3 files changed, 12 insertions(+), 3 deletions(-)
 create mode 100644 .upgradenotes/MDL-81321-2024052421223463.yml

diff --git a/.upgradenotes/MDL-81321-2024052421223463.yml b/.upgradenotes/MDL-81321-2024052421223463.yml
new file mode 100644
index 00000000000..b95697fe366
--- /dev/null
+++ b/.upgradenotes/MDL-81321-2024052421223463.yml
@@ -0,0 +1,7 @@
+issueNumber: MDL-81321
+notes:
+  mod_data:
+    - message: >-
+        The `mod_data_renderer::render_fields_footer` method has been deprecated
+        as it's no longer used
+      type: deprecated
diff --git a/mod/data/field.php b/mod/data/field.php
index d8c66abc2f1..01931bf70d9 100644
--- a/mod/data/field.php
+++ b/mod/data/field.php
@@ -470,9 +470,6 @@ if (($mode == 'new') && (!empty($newtype))) { // Adding a new field.
     echo '</div>';
     echo '</form>';
 
-    // Add a sticky footer.
-    echo $renderer->render_fields_footer($manager);
-
     echo '</div>';
 }
 
diff --git a/mod/data/renderer.php b/mod/data/renderer.php
index 2cea808f760..07d7a8d45b3 100644
--- a/mod/data/renderer.php
+++ b/mod/data/renderer.php
@@ -167,8 +167,13 @@ class mod_data_renderer extends plugin_renderer_base {
      *
      * @param manager $manager the instance manager
      * @return string The HTML output
+     *
+     * @deprecated since Moodle 4.5 - please do not use this function anymore
      */
+    #[\core\attribute\deprecated(null, reason: 'It is no longer used', since: '4.5')]
     public function render_fields_footer(manager $manager): string {
+        \core\deprecation::emit_deprecation_if_present([self::class, __FUNCTION__]);
+
         $cm = $manager->get_coursemodule();
         $pageurl = new moodle_url('/mod/data/templates.php', ['id' => $cm->id]);
         return $this->render_from_template('mod_data/fields_footer', [