diff --git a/admin/tool/dataprivacy/amd/src/data_registry.js b/admin/tool/dataprivacy/amd/src/data_registry.js index 76f00ee8e1e..07eb18dbe82 100644 --- a/admin/tool/dataprivacy/amd/src/data_registry.js +++ b/admin/tool/dataprivacy/amd/src/data_registry.js @@ -234,6 +234,7 @@ define(['jquery', 'core/str', 'core/ajax', 'core/notification', 'core/templates' }, fail: Notification.exception }]); + return; }).catch(Notification.exception); }; diff --git a/admin/tool/dataprivacy/amd/src/expand_contract.js b/admin/tool/dataprivacy/amd/src/expand_contract.js index 41b7e506eaf..cf509b5574a 100644 --- a/admin/tool/dataprivacy/amd/src/expand_contract.js +++ b/admin/tool/dataprivacy/amd/src/expand_contract.js @@ -34,7 +34,6 @@ define(['jquery', 'core/url', 'core/str'], function($, url, str) { * * @param {object} targetnode The node that we want to expand / collapse * @param {object} thisnode The node that was clicked. - * @return {null} */ expandCollapse: function(targetnode, thisnode) { if (targetnode.hasClass('hide')) { @@ -58,7 +57,6 @@ define(['jquery', 'core/url', 'core/str'], function($, url, str) { * Expand or collapse all nodes on this page. * * @param {string} nextstate The next state to change to. - * @return {null} */ expandCollapseAll: function(nextstate) { var currentstate = (nextstate == 'visible') ? 'hide' : 'visible'; @@ -75,6 +73,7 @@ define(['jquery', 'core/url', 'core/str'], function($, url, str) { str.get_string(currentstate, 'tool_dataprivacy').then(function(langString) { $('.tool_dataprivacy-expand-all').html(langString); + return; }).catch(Notification.exception); $(':header i.fa').each(function() { diff --git a/admin/tool/dataprivacy/categories.php b/admin/tool/dataprivacy/categories.php index b160ff3fd61..f323278844b 100644 --- a/admin/tool/dataprivacy/categories.php +++ b/admin/tool/dataprivacy/categories.php @@ -24,6 +24,8 @@ require_once(__DIR__ . '/../../../config.php'); +require_login(null, false); + $url = new moodle_url("/admin/tool/dataprivacy/categories.php"); $title = get_string('editcategories', 'tool_dataprivacy'); diff --git a/admin/tool/dataprivacy/classes/api.php b/admin/tool/dataprivacy/classes/api.php index 05efe9c98db..275044af6b9 100644 --- a/admin/tool/dataprivacy/classes/api.php +++ b/admin/tool/dataprivacy/classes/api.php @@ -197,7 +197,7 @@ class api { } else { // If not a DPO, only users with the capability to make data requests for the user should be allowed. // (e.g. users with the Parent role, etc). - if (!api::can_create_data_request_for_user($foruser)) { + if (!self::can_create_data_request_for_user($foruser)) { $forusercontext = \context_user::instance($foruser); throw new required_capability_exception($forusercontext, 'tool/dataprivacy:makedatarequestsforchildren', 'nopermissions', ''); diff --git a/admin/tool/dataprivacy/classes/data_registry.php b/admin/tool/dataprivacy/classes/data_registry.php index 39e3e531b7b..1435fcddb62 100644 --- a/admin/tool/dataprivacy/classes/data_registry.php +++ b/admin/tool/dataprivacy/classes/data_registry.php @@ -289,7 +289,8 @@ class data_registry { * @param int $forcedcategoryvalue Use this value as if this was this context level category. * @return int[] */ - public static function get_effective_default_contextlevel_purpose_and_category($contextlevel, $forcedpurposevalue = false, $forcedcategoryvalue = false) { + public static function get_effective_default_contextlevel_purpose_and_category($contextlevel, $forcedpurposevalue = false, + $forcedcategoryvalue = false) { list($purposeid, $categoryid) = self::get_defaults($contextlevel); diff --git a/admin/tool/dataprivacy/classes/expired_contexts_manager.php b/admin/tool/dataprivacy/classes/expired_contexts_manager.php index 3d20e5d0cc6..539fc289a48 100644 --- a/admin/tool/dataprivacy/classes/expired_contexts_manager.php +++ b/admin/tool/dataprivacy/classes/expired_contexts_manager.php @@ -23,10 +23,7 @@ */ namespace tool_dataprivacy; -use tool_dataprivacy\api; -use tool_dataprivacy\purpose; -use tool_dataprivacy\context_instance; -use tool_dataprivacy\data_registry; +use core_privacy\manager; use tool_dataprivacy\expired_context; defined('MOODLE_INTERNAL') || die(); @@ -90,7 +87,7 @@ abstract class expired_contexts_manager { return $numprocessed; } - $privacymanager = new \core_privacy\manager(); + $privacymanager = new manager(); $privacymanager->set_observer(new \tool_dataprivacy\manager_observer()); foreach ($this->get_context_levels() as $level) { @@ -118,11 +115,11 @@ abstract class expired_contexts_manager { /** * Deletes user data from the provided context. * - * @param \core_privacy\manager $privacymanager - * @param \tool_dataprivacy\expired_context $expiredctx + * @param manager $privacymanager + * @param expired_context $expiredctx * @return \context|false */ - protected function delete_expired_context(\core_privacy\manager $privacymanager, \tool_dataprivacy\expired_context $expiredctx) { + protected function delete_expired_context(manager $privacymanager, expired_context $expiredctx) { $context = \context::instance_by_id($expiredctx->get('contextid'), IGNORE_MISSING); if (!$context) { diff --git a/admin/tool/dataprivacy/classes/expired_user_contexts.php b/admin/tool/dataprivacy/classes/expired_user_contexts.php index e4b40e88a4d..924d5650132 100644 --- a/admin/tool/dataprivacy/classes/expired_user_contexts.php +++ b/admin/tool/dataprivacy/classes/expired_user_contexts.php @@ -23,8 +23,7 @@ */ namespace tool_dataprivacy; -use tool_dataprivacy\purpose; -use tool_dataprivacy\context_instance; +use core_privacy\manager; defined('MOODLE_INTERNAL') || die(); @@ -110,11 +109,11 @@ class expired_user_contexts extends \tool_dataprivacy\expired_contexts_manager { * * Overwritten to delete the user. * - * @param \core_privacy\manager $privacymanager - * @param \tool_dataprivacy\expired_context $expiredctx + * @param manager $privacymanager + * @param expired_context $expiredctx * @return \context|false */ - protected function delete_expired_context(\core_privacy\manager $privacymanager, \tool_dataprivacy\expired_context $expiredctx) { + protected function delete_expired_context(manager $privacymanager, expired_context $expiredctx) { $context = \context::instance_by_id($expiredctx->get('contextid'), IGNORE_MISSING); if (!$context) { api::delete_expired_context($expiredctx->get('contextid')); diff --git a/admin/tool/dataprivacy/classes/form/context_instance.php b/admin/tool/dataprivacy/classes/form/context_instance.php index 14790b51374..bd1204f08f3 100644 --- a/admin/tool/dataprivacy/classes/form/context_instance.php +++ b/admin/tool/dataprivacy/classes/form/context_instance.php @@ -27,6 +27,7 @@ defined('MOODLE_INTERNAL') || die(); use tool_dataprivacy\api; use tool_dataprivacy\data_registry; +use tool_dataprivacy\purpose; /** * Context instance data form. @@ -186,12 +187,12 @@ class context_instance extends \core\form\persistent { /** * Returns the purpose display text. * - * @param \tool_dataprivacy\purpose $effectivepurpose + * @param purpose $effectivepurpose * @param int $retentioncontextlevel * @param \context $context The context, just for displaying (filters) purposes. * @return string */ - protected static function get_retention_display_text(\tool_dataprivacy\purpose $effectivepurpose, $retentioncontextlevel, \context $context) { + protected static function get_retention_display_text(purpose $effectivepurpose, $retentioncontextlevel, \context $context) { global $PAGE; $renderer = $PAGE->get_renderer('tool_dataprivacy'); diff --git a/admin/tool/dataprivacy/classes/local/helper.php b/admin/tool/dataprivacy/classes/local/helper.php index d7c3436c388..c68c9947ef0 100644 --- a/admin/tool/dataprivacy/classes/local/helper.php +++ b/admin/tool/dataprivacy/classes/local/helper.php @@ -132,7 +132,7 @@ class helper { 'contextlevel' => CONTEXT_USER ]; - // The final list of users that we will return; + // The final list of users that we will return. $finalresults = []; // Our prospective list of users. diff --git a/admin/tool/dataprivacy/classes/purpose.php b/admin/tool/dataprivacy/classes/purpose.php index c1631e47a7d..ca4fb170515 100644 --- a/admin/tool/dataprivacy/classes/purpose.php +++ b/admin/tool/dataprivacy/classes/purpose.php @@ -64,7 +64,7 @@ class purpose extends \core\persistent { // Replicate self::read. $this->from_record($data); - // Using validate() as self::$validated is private. + // Validate the purpose record. $this->validate(); // Now replicate the parent constructor. diff --git a/admin/tool/dataprivacy/datadeletion.php b/admin/tool/dataprivacy/datadeletion.php index eaa5056abc2..f622e5b4ebb 100644 --- a/admin/tool/dataprivacy/datadeletion.php +++ b/admin/tool/dataprivacy/datadeletion.php @@ -25,6 +25,8 @@ require_once(__DIR__ . '/../../../config.php'); require_once($CFG->dirroot . '/' . $CFG->admin . '/tool/dataprivacy/lib.php'); +require_login(null, false); + $filter = optional_param('filter', CONTEXT_COURSE, PARAM_INT); $url = new moodle_url('/admin/tool/dataprivacy/datadeletion.php'); diff --git a/admin/tool/dataprivacy/dataregistry.php b/admin/tool/dataprivacy/dataregistry.php index 58da78550b7..52eff0a4cc4 100644 --- a/admin/tool/dataprivacy/dataregistry.php +++ b/admin/tool/dataprivacy/dataregistry.php @@ -25,6 +25,8 @@ require_once(__DIR__ . '/../../../config.php'); require_once($CFG->dirroot . '/' . $CFG->admin . '/tool/dataprivacy/lib.php'); +require_login(null, false); + $contextlevel = optional_param('contextlevel', CONTEXT_SYSTEM, PARAM_INT); $contextid = optional_param('contextid', 0, PARAM_INT); diff --git a/admin/tool/dataprivacy/datarequests.php b/admin/tool/dataprivacy/datarequests.php index d2d9123e082..a3e613a3cfd 100644 --- a/admin/tool/dataprivacy/datarequests.php +++ b/admin/tool/dataprivacy/datarequests.php @@ -25,6 +25,8 @@ require_once("../../../config.php"); require_once('lib.php'); +require_login(null, false); + $url = new moodle_url('/admin/tool/dataprivacy/datarequests.php'); $title = get_string('datarequests', 'tool_dataprivacy'); diff --git a/admin/tool/dataprivacy/defaults.php b/admin/tool/dataprivacy/defaults.php index 06119084c6f..d936ba221d6 100644 --- a/admin/tool/dataprivacy/defaults.php +++ b/admin/tool/dataprivacy/defaults.php @@ -25,6 +25,8 @@ require_once(__DIR__ . '/../../../config.php'); require_once($CFG->dirroot . '/' . $CFG->admin . '/tool/dataprivacy/lib.php'); +require_login(null, false); + $url = new \moodle_url('/admin/tool/dataprivacy/defaults.php'); $title = get_string('setdefaults', 'tool_dataprivacy'); diff --git a/admin/tool/dataprivacy/editcategory.php b/admin/tool/dataprivacy/editcategory.php index a2f59fb4d72..0ee630f0b83 100644 --- a/admin/tool/dataprivacy/editcategory.php +++ b/admin/tool/dataprivacy/editcategory.php @@ -24,6 +24,8 @@ require_once(__DIR__ . '/../../../config.php'); +require_login(null, false); + $id = optional_param('id', 0, PARAM_INT); $url = new \moodle_url('/admin/tool/dataprivacy/editcategory.php', array('id' => $id)); diff --git a/admin/tool/dataprivacy/editpurpose.php b/admin/tool/dataprivacy/editpurpose.php index d7013dbd4a4..20ee631f9c0 100644 --- a/admin/tool/dataprivacy/editpurpose.php +++ b/admin/tool/dataprivacy/editpurpose.php @@ -24,6 +24,8 @@ require_once(__DIR__ . '/../../../config.php'); +require_login(null, false); + $id = optional_param('id', 0, PARAM_INT); $url = new \moodle_url('/admin/tool/dataprivacy/editpurpose.php', array('id' => $id)); diff --git a/admin/tool/dataprivacy/pluginregistry.php b/admin/tool/dataprivacy/pluginregistry.php index 060bd81db69..3b3f1c47780 100644 --- a/admin/tool/dataprivacy/pluginregistry.php +++ b/admin/tool/dataprivacy/pluginregistry.php @@ -25,6 +25,8 @@ require_once(__DIR__ . '/../../../config.php'); require_once($CFG->dirroot . '/' . $CFG->admin . '/tool/dataprivacy/lib.php'); +require_login(null, false); + $contextlevel = optional_param('contextlevel', CONTEXT_SYSTEM, PARAM_INT); $contextid = optional_param('contextid', 0, PARAM_INT); diff --git a/admin/tool/dataprivacy/purposes.php b/admin/tool/dataprivacy/purposes.php index 81d15173055..5fad9222cdc 100644 --- a/admin/tool/dataprivacy/purposes.php +++ b/admin/tool/dataprivacy/purposes.php @@ -24,6 +24,8 @@ require_once(__DIR__ . '/../../../config.php'); +require_login(null, false); + $url = new moodle_url("/admin/tool/dataprivacy/purposes.php"); $title = get_string('editpurposes', 'tool_dataprivacy'); diff --git a/admin/tool/dataprivacy/templates/component_status.mustache b/admin/tool/dataprivacy/templates/component_status.mustache index 79c906386bb..c62dc0b65d9 100644 --- a/admin/tool/dataprivacy/templates/component_status.mustache +++ b/admin/tool/dataprivacy/templates/component_status.mustache @@ -46,7 +46,7 @@ } }} -
| Name | Information | Purpose | Category | Retention period | ExpirySort by Expiry Ascending | |
|---|---|---|---|---|---|---|
| Miscellaneous / TC 1 | 7 children | Default purpose | Default category | 1 days | Thursday, 5 April 2018, 10:29 AM |
| This is the table that will contain the list of expired contexts |
{{#str}}emailsalutation, tool_dataprivacy, {{dponame}}{{/str}}
-{{#str}}requestemailintro, tool_dataprivacy{{/str}}
-| - {{#str}}requesttype, tool_dataprivacy{{/str}} - | -- {{requesttype}} - | -
|---|---|
| - {{#str}}requestfor, tool_dataprivacy{{/str}} - | -- {{requestfor}} - | -
| - {{#str}}requestby, tool_dataprivacy{{/str}} - | -- {{requestedby}} - | -
| - {{#str}}requestcomments, tool_dataprivacy{{/str}} - | -- {{{requestcomments}}} - | -
| - {{#str}}daterequested, tool_dataprivacy{{/str}} - | -- {{requestdate}} - | -
{{#str}}emailsalutation, tool_dataprivacy, {{dponame}}{{/str}}
+{{#str}}requestemailintro, tool_dataprivacy{{/str}}
+| + {{#str}}requesttype, tool_dataprivacy{{/str}} + | ++ {{requesttype}} + | +
|---|---|
| + {{#str}}requestfor, tool_dataprivacy{{/str}} + | ++ {{requestfor}} + | +
| + {{#str}}requestby, tool_dataprivacy{{/str}} + | ++ {{requestedby}} + | +
| + {{#str}}requestcomments, tool_dataprivacy{{/str}} + | ++ {{{requestcomments}}} + | +
| + {{#str}}daterequested, tool_dataprivacy{{/str}} + | ++ {{requestdate}} + | +