From cd3f250f32a81b6fa381119302d500482c741e94 Mon Sep 17 00:00:00 2001 From: Jun Pataleta Date: Fri, 4 Aug 2017 09:07:36 +0800 Subject: [PATCH 1/3] MDL-59366 core_user: Disable sorting for roles and groups columns --- user/classes/participants_table.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/user/classes/participants_table.php b/user/classes/participants_table.php index 2bc24c69ced..aa8e2f9f203 100644 --- a/user/classes/participants_table.php +++ b/user/classes/participants_table.php @@ -204,6 +204,8 @@ class participants_table extends \table_sql { $this->sortable(true, 'firstname'); $this->no_sorting('select'); + $this->no_sorting('roles'); + $this->no_sorting('groups'); $this->set_attribute('id', 'participants'); From 37fc1d4db74b94e5ee91735f5895e86256ceb33b Mon Sep 17 00:00:00 2001 From: Jun Pataleta Date: Fri, 4 Aug 2017 09:08:33 +0800 Subject: [PATCH 2/3] MDL-59366 enrol: Be more specific on which autocomplete is being opened * Specify that the autocomplete in the student's row in the participants table is being opened. --- enrol/tests/behat/add_to_group.feature | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/enrol/tests/behat/add_to_group.feature b/enrol/tests/behat/add_to_group.feature index 9e392448092..282f452751d 100644 --- a/enrol/tests/behat/add_to_group.feature +++ b/enrol/tests/behat/add_to_group.feature @@ -28,9 +28,9 @@ Feature: Users can be added to multiple groups at once And I am on "Course 1" course homepage And I follow "Participants" And I click on "Edit groups for \"Student 1\"" "link" in the "student1" "table_row" - And I open the autocomplete suggestions list + And I click on ".form-autocomplete-downarrow" "css_element" in the "student1" "table_row" And I click on "Group 1" item in the autocomplete list - And I open the autocomplete suggestions list + And I click on ".form-autocomplete-downarrow" "css_element" in the "student1" "table_row" And I click on "Group 2" item in the autocomplete list And I press key "27" in the field "Edit groups for \"Student 1\"" And I click on "Save changes" "link" in the "student1" "table_row" From b29c2fad0b7ec9d5de61fb06569c712d7620a14d Mon Sep 17 00:00:00 2001 From: Jun Pataleta Date: Fri, 4 Aug 2017 09:12:19 +0800 Subject: [PATCH 3/3] MDL-59366 user: Be more specific on which autocomplete is being opened MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Specify that the autocomplete in the student's row in the   participants table is being opened --- user/tests/behat/edit_user_roles.feature | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/user/tests/behat/edit_user_roles.feature b/user/tests/behat/edit_user_roles.feature index 63d153257fa..90ff654358c 100644 --- a/user/tests/behat/edit_user_roles.feature +++ b/user/tests/behat/edit_user_roles.feature @@ -25,7 +25,7 @@ Feature: Edit user roles And I am on "Course 1" course homepage And I navigate to course participants And I click on "Student 1's role assignments" "link" - And I open the autocomplete suggestions list + And I click on ".form-autocomplete-downarrow" "css_element" in the "student1" "table_row" And I click on "Non-editing teacher" item in the autocomplete list And I press key "27" in the field "Student 1's role assignments" When I click on "Save changes" "link"