diff --git a/mod/feedback/complete.php b/mod/feedback/complete.php
index e30f24ed3e8..c2beddd0257 100644
--- a/mod/feedback/complete.php
+++ b/mod/feedback/complete.php
@@ -339,64 +339,75 @@ if($feedback_can_submit) {
}
}else {
if(isset($savereturn) && $savereturn == 'failed') {
- echo '
'.get_string('saving_failed','feedback').'
';
+ echo ''.get_string('saving_failed','feedback').'
';
}
if(isset($savereturn) && $savereturn == 'missing') {
- echo ''.get_string('saving_failed_because_missing_or_false_values','feedback').'
';
+ echo ''.get_string('saving_failed_because_missing_or_false_values','feedback').'
';
}
//print the items
if(is_array($feedbackitems)){
- echo $OUTPUT->box_start('generalbox boxaligncenter boxwidthwide');
- echo '';
-
- if($courseid) {
- echo '
';
- }else{
- if($course->id == SITEID) {
- echo ' ';
- } else {
- echo ' ';
- }
+ echo ' ';
+
+ echo '';
+ if($courseid) {
+ echo '
';
+ }else{
+ if($course->id == SITEID) {
+ echo ' ';
+ } else {
+ echo ' ';
}
+ }
+ echo '';
echo ' ';
echo ' ';
echo ''.get_string('cancel').' ';
+ echo ' ';
echo ' ';
echo '';
$SESSION->feedback->is_started = true;
- echo $OUTPUT->box_end();
+ // echo $OUTPUT->box_end();
}
}
}else {
diff --git a/mod/feedback/edit.php b/mod/feedback/edit.php
index 51c16321c4e..cb3bd1a5971 100644
--- a/mod/feedback/edit.php
+++ b/mod/feedback/edit.php
@@ -214,6 +214,8 @@ if($do_show == 'edit') {
if(is_array($feedbackitems)){
$itemnr = 0;
+
+ $align = right_to_left() ? 'right' : 'left';
$helpbutton = $OUTPUT->help_icon('preview', 'feedback');
@@ -221,7 +223,7 @@ if($do_show == 'edit') {
if(isset($SESSION->feedback->moving) AND $SESSION->feedback->moving->shouldmoving == 1) {
echo $OUTPUT->heading(''.get_string('cancel_moving', 'feedback').' ');
}
- echo $OUTPUT->box_start('generalbox boxaligncenter boxwidthwide');
+ // echo $OUTPUT->box_start('generalbox boxaligncenter boxwidthwide');
//check, if there exists required-elements
$countreq = $DB->count_records('feedback_item', array('feedback'=>$feedback->id, 'required'=> 1));
@@ -230,189 +232,137 @@ if($do_show == 'edit') {
echo '(*)' . get_string('items_are_required', 'feedback') . ' ';
}
- echo '';
- if(isset($SESSION->feedback->moving) AND $SESSION->feedback->moving->shouldmoving == 1) {
- $moveposition = 1;
- $movehereurl = new moodle_url($url, array('movehere'=>$moveposition));
- echo ''; //only shown if shouldmoving = 1
- echo '';
- $buttonlink = $movehereurl->out();
- echo '
-
- ';
-
- // echo '';
- // echo ' ';
- // echo ' ';
- // feedback_edit_print_default_form_values($id, $do_show);
- // echo ' ';
- echo ' ';
- echo ' ';
- }
- //print the inserted items
- $itempos = 0;
- foreach($feedbackitems as $feedbackitem){
- $itempos++;
- if(isset($SESSION->feedback->moving) AND $SESSION->feedback->moving->movingitem == $feedbackitem->id){ //hiding the item to move
- continue;
- }
- echo '';
- //items without value only are labels
- if($feedbackitem->hasvalue == 1 AND $feedback->autonumbering) {
- $itemnr++;
- echo '' . $itemnr . '. ';
- } else {
- echo ' ';
- }
- if($feedbackitem->typ != 'pagebreak') {
- feedback_print_item_preview($feedbackitem);
- }else {
- echo ''.get_string('pagebreak', 'feedback').' ';
- }
- echo '('.get_string('position', 'feedback').':'.$itempos .') ';
- echo '';
- if($feedbackitem->position > 1){
- $moveupurl = new moodle_url($url, array('moveupitem'=>$feedbackitem->id));
- $buttonlink = $moveupurl->out();
- echo '
-
- ';
- //print the button to move-up the item
- // echo '';
- // ///////echo ' ';
- // echo ' ';
- // echo ' ';
- // feedback_edit_print_default_form_values($id, $do_show);
- // echo ' ';
- }else{
- echo ' ';
- }
- echo ' ';
- echo '';
- if($feedbackitem->position < $lastposition - 1){
- $movedownurl = new moodle_url($url, array('movedownitem'=>$feedbackitem->id));
- $buttonlink = $movedownurl->out();
- echo '
-
- ';
- //print the button to move-down the item
- // echo '';
- // echo ' ';
- // echo ' ';
- // echo ' ';
- // feedback_edit_print_default_form_values($id, $do_show);
- // echo ' ';
- }else{
- echo ' ';
- }
- echo ' ';
- echo '';
- $moveurl = new moodle_url($url, array('moveitem'=>$feedbackitem->id));
- $buttonlink = $moveurl->out();
- echo '
-
- ';
- // echo '';
- // echo ' ';
- // echo ' ';
- // echo ' ';
- // feedback_edit_print_default_form_values($id, $do_show);
- // echo ' ';
- echo ' ';
- echo '';
- //print the button to edit the item
- if($feedbackitem->typ != 'pagebreak') {
- $editurl = new moodle_url('/mod/feedback/edit_item.php');
- $editurl->params(array('do_show'=>$do_show,
- 'cmid'=>$id,
- 'id'=>$feedbackitem->id,
- 'typ'=>$feedbackitem->typ));
-
- // in edit_item.php the param id is used for the itemid and the cmid is the id to get the module
- $buttonlink = $editurl->out();
- echo '
-
- ';
- // echo '';
- // echo ' ';
- // echo ' ';
- // echo ' ';
- // echo ' ';
- // feedback_edit_print_default_form_values($id, $do_show);
- // echo ' ';
- }else {
- echo ' ';
- }
- echo ' ';
- echo '';
-
- //print the toggle-button to switch required yes/no
- if($feedbackitem->hasvalue == 1) {
- // echo '';
- if($feedbackitem->required == 1) {
- // echo ' ';
- // echo ' ';
- $buttontitle = get_string('switch_item_to_not_required','feedback');
- $buttonimg = 'pics/required.gif';
- } else {
- // echo ' ';
- // echo ' ';
- $buttontitle = get_string('switch_item_to_required','feedback');
- $buttonimg = 'pics/notrequired.gif';
- }
- $requiredurl = new moodle_url($url, array('switchitemrequired'=>$feedbackitem->id));
- $buttonlink = $requiredurl->out();
- echo '
-
- ';
- // echo ' ';
- // feedback_edit_print_default_form_values($id, $do_show);
- // echo ' ';
- }else {
- echo ' ';
- }
- echo ' ';
- echo '';
- $deleteitemurl = new moodle_url('/mod/feedback/delete_item.php');
- $deleteitemurl->params(array('id'=>$id,
- 'do_show'=>$do_show,
- 'deleteitem'=>$feedbackitem->id));
-
- $buttonlink = $deleteitemurl->out();
- echo '
-
- ';
- //print the button to drop the item
- // echo '';
- // echo ' ';
- // echo ' ';
- // feedback_edit_print_default_form_values($id, $do_show);
- // echo ' ';
- echo ' ';
- echo ' ';
+ //use list instead a table
+ echo '';
if(isset($SESSION->feedback->moving) AND $SESSION->feedback->moving->shouldmoving == 1) {
- $moveposition++;
- $movehereurl->param('movehere', $moveposition);
- echo '
'; //only shown if shouldmoving = 1
- echo '';
- $buttonlink = $movehereurl->out();
- echo '
-
- ';
- // echo '';
- // echo ' ';
- // echo ' ';
- // feedback_edit_print_default_form_values($id, $do_show);
- // echo ' ';
- echo ' ';
- echo ' ';
- }else {
- echo '
';
+ $moveposition = 1;
+ $movehereurl = new moodle_url($url, array('movehere'=>$moveposition));
+ echo '
'; //only shown if shouldmoving = 1
+ $buttonlink = $movehereurl->out();
+ echo '
+
+ ';
+ echo '
';
}
+ //print the inserted items
+ $itempos = 0;
+ foreach($feedbackitems as $feedbackitem){
+ $itempos++;
+ if(isset($SESSION->feedback->moving) AND $SESSION->feedback->moving->movingitem == $feedbackitem->id){ //hiding the item to move
+ continue;
+ }
+ echo '
';
+ //items without value only are labels
+ if($feedbackitem->hasvalue == 1 AND $feedback->autonumbering) {
+ $itemnr++;
+ echo '
' . $itemnr . '
';
+ }
+ echo '
';
+ echo '
';
+ echo '
('.get_string('position', 'feedback').':'.$itempos .') ';
+ //print the moveup-button
+ if($feedbackitem->position > 1){
+ echo '
';
+ $moveupurl = new moodle_url($url, array('moveupitem'=>$feedbackitem->id));
+ $buttonlink = $moveupurl->out();
+ echo '
+
+ ';
+ echo ' ';
+ }
+ //print the movedown-button
+ if($feedbackitem->position < $lastposition - 1){
+ echo '
';
+ $movedownurl = new moodle_url($url, array('movedownitem'=>$feedbackitem->id));
+ $buttonlink = $movedownurl->out();
+ echo '
+
+ ';
+ echo ' ';
+ }
+ //print the move-button
+ echo '
';
+ $moveurl = new moodle_url($url, array('moveitem'=>$feedbackitem->id));
+ $buttonlink = $moveurl->out();
+ echo '
+
+ ';
+ echo ' ';
+ //print the button to edit the item
+ if($feedbackitem->typ != 'pagebreak') {
+ echo '
';
+ $editurl = new moodle_url('/mod/feedback/edit_item.php');
+ $editurl->params(array('do_show'=>$do_show,
+ 'cmid'=>$id,
+ 'id'=>$feedbackitem->id,
+ 'typ'=>$feedbackitem->typ));
+
+ // in edit_item.php the param id is used for the itemid and the cmid is the id to get the module
+ $buttonlink = $editurl->out();
+ echo '
+
+ ';
+ echo ' ';
+ }
- }
- echo '
';
- echo $OUTPUT->box_end();
+ //print the toggle-button to switch required yes/no
+ if($feedbackitem->hasvalue == 1) {
+ echo '';
+ // echo '';
+ if($feedbackitem->required == 1) {
+ // echo ' ';
+ // echo ' ';
+ $buttontitle = get_string('switch_item_to_not_required','feedback');
+ $buttonimg = 'pics/required.gif';
+ } else {
+ // echo ' ';
+ // echo ' ';
+ $buttontitle = get_string('switch_item_to_required','feedback');
+ $buttonimg = 'pics/notrequired.gif';
+ }
+ $requiredurl = new moodle_url($url, array('switchitemrequired'=>$feedbackitem->id));
+ $buttonlink = $requiredurl->out();
+ echo '
+
+ ';
+ echo ' ';
+ }
+
+ //print the delete-button
+ echo '';
+ $deleteitemurl = new moodle_url('/mod/feedback/delete_item.php');
+ $deleteitemurl->params(array('id'=>$id,
+ 'do_show'=>$do_show,
+ 'deleteitem'=>$feedbackitem->id));
+
+ $buttonlink = $deleteitemurl->out();
+ echo '
+
+ ';
+ echo ' ';
+ echo '';
+ if($feedbackitem->typ != 'pagebreak') {
+ // echo '';
+ feedback_print_item_preview($feedbackitem);
+ }else {
+ echo '
'.get_string('pagebreak', 'feedback').'
';
+ }
+ echo '
';
+ echo '';
+ if(isset($SESSION->feedback->moving) AND $SESSION->feedback->moving->shouldmoving == 1) {
+ $moveposition++;
+ $movehereurl->param('movehere', $moveposition);
+ echo ''; //only shown if shouldmoving = 1
+ $buttonlink = $movehereurl->out();
+ echo '
+
+ ';
+ echo '
';
+ }
+ echo '
';
+ }
+ echo '';
+ // echo $OUTPUT->box_end();
}else{
echo $OUTPUT->box(get_string('no_items_available_yet','feedback'),'generalbox boxaligncenter');
}
diff --git a/mod/feedback/item/captcha/lib.php b/mod/feedback/item/captcha/lib.php
index 2ebc976c895..268b9ed9799 100644
--- a/mod/feedback/item/captcha/lib.php
+++ b/mod/feedback/item/captcha/lib.php
@@ -124,24 +124,23 @@ class feedback_item_captcha extends feedback_item_base {
}
$requiredmark = ($item->required == 1)?'* ':'';
- ?>
-
- label.') ';
- echo format_text($item->name . $requiredmark, true, false, false);
+
+ //print the question and label
+ echo '';
+ echo '('.$item->label.') ';
+ echo format_text($item->name.$requiredmark, true, false, false);
+ echo '
';
+
+ //print the presentation
+ echo '';
$imglink = new moodle_url('/mod/feedback/item/captcha/print_captcha.php', array('id'=>$cmid));
- ?>
-
-
-
-
-
-
- ';
+ echo ' ';
+ echo '';
+ echo '';
+ echo ' ';
+ echo '
';
+ echo '';
}
/**
@@ -185,26 +184,27 @@ class feedback_item_captcha extends feedback_item_base {
}
if(($highlightrequire AND $item->required AND !$checked) OR $falsevalue) {
- $highlight = 'bgcolor="#FFAAAA" class="missingrequire"';
+ $highlight = ' missingrequire';
}else {
$highlight = '';
}
$requiredmark = ($item->required == 1)?'* ':'';
- ?>
- valign="top" align="">
- name . $requiredmark, true, false, false);
+
+ //print the question and label
+ echo '';
+ echo format_text($item->name.$requiredmark, true, false, false);
+ echo '
';
+
+ //print the presentation
+ echo '';
+ echo '
';
$imglink = new moodle_url('/mod/feedback/item/captcha/print_captcha.php', array('id'=>$cmid));
- ?>
-
-
-
-
-
- type.'" src="'.$imglink->out().'" />';
+ echo '';
+ echo '';
+ echo ' ';
+ echo '
';
+ echo '';
}
/**
@@ -233,23 +233,23 @@ class feedback_item_captcha extends feedback_item_base {
}
$requiredmark = ($item->required == 1)?'* ':'';
- ?>
-
- ';
echo '('.$item->label.') ';
echo format_text($item->name . $requiredmark, true, false, false);
+ echo '';
+
+ //print the presentation
+ echo '';
+ echo '
';
$imglink = new moodle_url('/mod/feedback/item/captcha/print_captcha.php', array('id'=>$cmid));
- ?>
-
-
-
- box_start('generalbox boxalign'.$align);
- echo $value ? $value : ' ';
- echo $OUTPUT->box_end();
- ?>
-
- type.'" src="'.$imglink->out().'" />';
+ echo '';
+ echo $OUTPUT->box_start('generalbox boxalign'.$align);
+ echo $value ? $value : ' ';
+ echo $OUTPUT->box_end();
+ echo '';
}
diff --git a/mod/feedback/item/info/info_form.php b/mod/feedback/item/info/info_form.php
index 3fdc8ab1800..b1d53a0c177 100644
--- a/mod/feedback/item/info/info_form.php
+++ b/mod/feedback/item/info/info_form.php
@@ -23,8 +23,8 @@ class feedback_info_form extends feedback_item_form {
$options=array();
$options[1] = get_string('responsetime', 'feedback');
- $options[2] = get_string('coursename', 'feedback');
- $options[3] = get_string('coursecategory', 'feedback');
+ $options[2] = get_string('course');
+ $options[3] = get_string('coursecategory');
$this->infotype = &$mform->addElement('select', 'presentation', get_string('infotype', 'feedback'), $options);
////////////////////////////////////////////////////////////////////////
diff --git a/mod/feedback/item/info/lib.php b/mod/feedback/item/info/lib.php
index 15efb0ec2bf..5b8c4eb2881 100644
--- a/mod/feedback/item/info/lib.php
+++ b/mod/feedback/item/info/lib.php
@@ -163,38 +163,35 @@ class feedback_item_info extends feedback_item_base {
$presentation = $item->presentation;
$requiredmark = ($item->required == 1)?'* ':'';
- ?>
-
- label.') ';
- echo format_text($item->name . $requiredmark, true, false, false);
- ?>
-
-
- get_record('feedback', array('id'=>$item->feedback));
- $course = $DB->get_record('course', array('id'=>$feedback->course));
- $coursecategory = $DB->get_record('course_categories', array('id'=>$course->category));
- switch($presentation) {
- case 1:
- $itemvalue = time();
- $itemshowvalue = UserDate($itemvalue);
- break;
- case 2:
- $itemvalue = $course->shortname;
- $itemshowvalue = $itemvalue;
- break;
- case 3:
- $itemvalue = $coursecategory->name;
- $itemshowvalue = $itemvalue;
- break;
- }
- ?>
-
-
-
- get_record('feedback', array('id'=>$item->feedback));
+ $course = $DB->get_record('course', array('id'=>$feedback->course));
+ $coursecategory = $DB->get_record('course_categories', array('id'=>$course->category));
+ switch($presentation) {
+ case 1:
+ $itemvalue = time();
+ $itemshowvalue = UserDate($itemvalue);
+ break;
+ case 2:
+ $itemvalue = $course->shortname;
+ $itemshowvalue = $itemvalue;
+ break;
+ case 3:
+ $itemvalue = $coursecategory->name;
+ $itemshowvalue = $itemvalue;
+ break;
+ }
+
+ //print the question and label
+ echo '';
+ echo '('.$item->label.') ';
+ echo format_text($item->name.$requiredmark, true, false, false);
+ echo '
';
+ //print the presentation
+ echo '';
+ echo ' ';
+ echo ''.$itemshowvalue.' ';
+ echo '
';
}
/**
@@ -212,42 +209,40 @@ class feedback_item_info extends feedback_item_base {
$presentation = $item->presentation;
if($highlightrequire AND $item->required AND strval($value) == '') {
- $highlight = 'bgcolor="#FFAAAA" class="missingrequire"';
+ $highlight = ' missingrequire';
}else {
$highlight = '';
}
$requiredmark = ($item->required == 1)?'* ':'';
- ?>
- valign="top" align="">
- name . $requiredmark, true, false, false);
- ?>
-
-
- get_record('feedback', array('id'=>$item->feedback));
- $course = $DB->get_record('course', array('id'=>$feedback->course));
- $coursecategory = $DB->get_record('course_categories', array('id'=>$course->category));
- switch($presentation) {
- case 1:
- $itemvalue = time();
- $itemshowvalue = UserDate($itemvalue);
- break;
- case 2:
- $itemvalue = $course->shortname;
- $itemshowvalue = $itemvalue;
- break;
- case 3:
- $itemvalue = $coursecategory->name;
- $itemshowvalue = $itemvalue;
- break;
- }
- ?>
-
-
-
- get_record('feedback', array('id'=>$item->feedback));
+ $course = $DB->get_record('course', array('id'=>$feedback->course));
+ $coursecategory = $DB->get_record('course_categories', array('id'=>$course->category));
+ switch($presentation) {
+ case 1:
+ $itemvalue = time();
+ $itemshowvalue = UserDate($itemvalue);
+ break;
+ case 2:
+ $itemvalue = $course->shortname;
+ $itemshowvalue = $itemvalue;
+ break;
+ case 3:
+ $itemvalue = $coursecategory->name;
+ $itemshowvalue = $itemvalue;
+ break;
+ }
+
+ //print the question and label
+ echo '';
+ echo format_text($item->name.$requiredmark, true, false, false);
+ echo '
';
+
+ //print the presentation
+ echo '';
+ echo ' ';
+ echo ''.$itemshowvalue.' ';
+ echo '
';
}
/**
@@ -264,21 +259,17 @@ class feedback_item_info extends feedback_item_base {
$presentation = $item->presentation;
$requiredmark = ($item->required == 1)?'* ':'';
- ?>
-
- ';
echo '('.$item->label.') ';
echo format_text($item->name . $requiredmark, true, false, false);
- ?>
-
-
- box_start('generalbox boxalign'.$align);
- echo $value ? UserDate($value):' ';
- echo $OUTPUT->box_end();
- ?>
-
- ';
+
+ //print the presentation
+ echo $OUTPUT->box_start('generalbox boxalign'.$align);
+ echo $value ? UserDate($value):' ';
+ echo $OUTPUT->box_end();
}
function check_value($value, $item) {
diff --git a/mod/feedback/item/label/lib.php b/mod/feedback/item/label/lib.php
index c39be18fc0a..3ef4a70677b 100644
--- a/mod/feedback/item/label/lib.php
+++ b/mod/feedback/item/label/lib.php
@@ -116,14 +116,8 @@ class feedback_item_label extends feedback_item_base {
$item->presentationformat = FORMAT_HTML;
$item->presentationtrust = 1;
- ?>
-
- presentation, 'pluginfile.php', $context->id, $filearea, $item->id);
- echo format_text($output, FORMAT_HTML);
- ?>
-
- presentation, 'pluginfile.php', $context->id, $filearea, $item->id);
+ echo format_text($output, FORMAT_HTML);
}
/**
diff --git a/mod/feedback/item/multichoice/lib.php b/mod/feedback/item/multichoice/lib.php
index aeb8080485d..b5460664aa7 100644
--- a/mod/feedback/item/multichoice/lib.php
+++ b/mod/feedback/item/multichoice/lib.php
@@ -249,44 +249,37 @@ class feedback_item_multichoice extends feedback_item_base {
//test if required and no value is set so we have to mark this item
//we have to differ check and the other subtypes
- if($info->subtype == 'c') {
- $requiredmark = ($item->required == 1)?'* ':'';
-
- echo '';
- echo '('.$item->label.') ';
- echo format_text($item->name.$requiredmark, true, false, false).' ';
- echo '';
- }else {
- $requiredmark = ($item->required == 1)?'* ':'';
- ?>
-
- label.') ';
- echo format_text($item->name . $requiredmark, true, false, false);
- ?>
-
-
- required == 1) ? '* ' : '';
+
+ //print the question and label
+ echo '';
+ echo '('.$item->label.') ';
+ echo format_text($item->name.$requiredmark, true, false, false);
+ echo '
';
+
+ //print the presentation
+ echo '';
$index = 1;
$checked = '';
- //print the "not_selected" item on radiobuttons
- if($info->subtype == 'r') {
- ?>
-
- ';
+ if($info->horizontal) {
+ $hv = 'h';
+ }else {
+ $hv = 'v';
}
- if($info->subtype != 'd') {
- if($info->horizontal) {
- echo '
';
- }
- }
- /*
- if($item->required == 1) {
- echo '
';
- }
- */
- ?>
-
- ';
+ echo '';
}
/**
@@ -342,53 +323,47 @@ class feedback_item_multichoice extends feedback_item_base {
$values = explode(FEEDBACK_MULTICHOICE_LINE_SEP, $value);
}
if($highlightrequire AND $item->required AND $values[0] == '') {
- $highlight = 'bgcolor="#FFAAAA" class="missingrequire"';
+ $highlight = ' missingrequire';
}else {
$highlight = '';
}
$requiredmark = ($item->required == 1)?'* ':'';
-
- echo '';
- echo format_text($item->name.$requiredmark, true, false, false).' ';
- echo '';
}else {
if($highlightrequire AND $item->required AND intval($value) <= 0) {
- $highlight = 'bgcolor="#FFAAAA" class="missingrequire"';
+ $highlight = ' missingrequire';
}else {
$highlight = '';
}
$requiredmark = ($item->required == 1)?'* ':'';
- ?>
- valign="top" align="">
- name . $requiredmark, true, false, false);
- ?>
-
-
- ';
+ echo format_text($item->name.$requiredmark, true, false, false);
+ echo '';
+
+ //print the presentation
+ echo '
- ';
+ echo '';
}
/**
@@ -442,31 +405,27 @@ class feedback_item_multichoice extends feedback_item_base {
$values = explode(FEEDBACK_MULTICHOICE_LINE_SEP, $value);
}
$requiredmark = ($item->required == 1)?'* ':'';
-
- echo '';
- echo '('.$item->label.') ';
- echo format_text($item->name.$requiredmark, true, false, false).' ';
- echo '';
}else {
$requiredmark = ($item->required == 1)?'* ':'';
- ?>
-
- label.') ';
- echo format_text($item->name . $requiredmark, true, false, false);
- ?>
-
-
- ';
+ echo '('.$item->label.') ';
+ echo format_text($item->name . $requiredmark, true, false, false);
+ echo '';
+
+ //print the presentation
+ echo '';
$index = 1;
- $checked = '';
if($info->subtype == 'c') {
echo $OUTPUT->box_start('generalbox boxalign'.$align);
foreach($presentation as $pres){
foreach($values as $val) {
if($val == $index){
- echo text_to_html($pres . '
', true, false, false);
+ echo '
';
+ echo text_to_html($pres, true, false, false);
+ echo '
';
break;
}
}
@@ -484,9 +443,7 @@ class feedback_item_multichoice extends feedback_item_base {
$index++;
}
}
- ?>
-
- ';
}
function check_value($value, $item) {
@@ -573,6 +530,13 @@ class feedback_item_multichoice extends feedback_item_base {
function print_item_radio($presentation, $item, $value, $info, $align) {
$index = 1;
$checked = '';
+
+ if($info->horizontal) {
+ $hv = 'h';
+ }else {
+ $hv = 'v';
+ }
+
foreach($presentation as $radio){
if($value == $index){
$checked = 'checked="checked"';
@@ -581,28 +545,16 @@ class feedback_item_multichoice extends feedback_item_base {
}
$inputname = $item->typ . '_' . $item->id;
$inputid = $inputname.'_'.$index;
- if($info->horizontal) {
?>
- />
-
-
+
+
+ />
+
+
-
+
+
-
- horizontal) {
+ $hv = 'h';
+ }else {
+ $hv = 'v';
+ }
$index = 1;
$checked = '';
@@ -628,50 +586,48 @@ class feedback_item_multichoice extends feedback_item_base {
}
$inputname = $item->typ. '_' . $item->id;
$inputid = $item->typ. '_' . $item->id.'_'.$index;
- if($info->horizontal) {
?>
- />
-
-
+
+
+ />
+
+
+
+
+
-
-
-
-
-
- >
- horizontal) {
+ $hv = 'h';
+ }else {
+ $hv = 'v';
}
+
?>
-
+
+
+
+
+ >
+
+
+
presentation);
$requiredmark = ($item->required == 1)?'* ':'';
- ?>
-
- label.') ';
- echo format_text($item->name . $requiredmark, true, false, false);
- ?>
-
-
- ';
+ echo '('.$item->label.') ';
+ echo format_text($item->name.$requiredmark, true, false, false);
+ echo '';
+
+ //print the presentation
+ echo '';
switch($info->subtype) {
case 'r':
$this->print_item_radio($item, false, $info, $align, true, $lines);
@@ -255,9 +252,7 @@ class feedback_item_multichoicerated extends feedback_item_base {
$this->print_item_dropdown($item, false, $info, $align, true, $lines);
break;
}
- ?>
-
- ';
}
/**
@@ -277,20 +272,18 @@ class feedback_item_multichoicerated extends feedback_item_base {
$lines = explode (FEEDBACK_MULTICHOICERATED_LINE_SEP, $info->presentation);
$requiredmark = ($item->required == 1)?'* ':'';
if($highlightrequire AND $item->required AND intval($value) <= 0) {
- $highlight = 'bgcolor="#FFAAAA" class="missingrequire"';
+ $highlight = ' missingrequire';
}else {
$highlight = '';
}
- ?>
- valign="top" align="">
- name . $requiredmark, true, false, false);
- ?>
-
-
- ';
+ echo format_text($item->name.$requiredmark, true, false, false);
+ echo '';
+
+ //print the presentation
+ echo '';
switch($info->subtype) {
case 'r':
$this->print_item_radio($item, $value, $info, $align, false, $lines);
@@ -299,9 +292,7 @@ class feedback_item_multichoicerated extends feedback_item_base {
$this->print_item_dropdown($item, $value, $info, $align, false, $lines);
break;
}
- ?>
-
- ';
}
/**
@@ -319,17 +310,16 @@ class feedback_item_multichoicerated extends feedback_item_base {
$lines = explode (FEEDBACK_MULTICHOICERATED_LINE_SEP, $info->presentation);
$requiredmark = ($item->required == 1)?'* ':'';
- ?>
-
- ';
echo '('.$item->label.') ';
echo format_text($item->name . $requiredmark, true, false, false);
- ?>
-
-
- ';
+
+ //print the presentation
+ echo '';
$index = 1;
- $checked = '';
foreach($lines as $line){
if($value == $index){
$item_value = explode(FEEDBACK_MULTICHOICERATED_VALUE_SEP, $line);
@@ -340,9 +330,7 @@ class feedback_item_multichoicerated extends feedback_item_base {
}
$index++;
}
- ?>
-
- ';
}
function check_value($value, $item) {
@@ -409,21 +397,23 @@ class feedback_item_multichoicerated extends feedback_item_base {
function print_item_radio($item, $value, $info, $align, $showrating, $lines) {
$index = 1;
$checked = '';
- ?>
-
- horizontal) {
- echo '';
+ $hv = 'h';
+ }else {
+ $hv = 'v';
}
+ echo '
';
- }
+ echo '';
}
function print_item_dropdown($item, $value, $info, $align, $showrating, $lines) {
- echo '';
- echo ' ';
- $index = 1;
- $checked = '';
- foreach($lines as $line){
- if($value == $index){
- $selected = 'selected="selected"';
- }else{
- $selected = '';
- }
- $dropdown_value = explode(FEEDBACK_MULTICHOICERATED_VALUE_SEP, $line);
- if($showrating) {
- echo ''. clean_text('('.$dropdown_value[0].') '.$dropdown_value[1]).' ';
- }else {
- echo ''. clean_text($dropdown_value[1]).' ';
- }
- $index++;
+ if($info->horizontal) {
+ $hv = 'h';
+ }else {
+ $hv = 'v';
}
- echo ' ';
-
+ echo '';
+ ?>
+
+
+
+ '.clean_text('('.$dropdown_value[0].') '.$dropdown_value[1]).'';
+ }else {
+ echo ''.clean_text($dropdown_value[1]).' ';
+ }
+ $index++;
+ }
+ ?>
+
+
+ ';
}
function prepare_presentation_values($linesep1, $linesep2, $valuestring, $valuesep1, $valuesep2) {
diff --git a/mod/feedback/item/numeric/lib.php b/mod/feedback/item/numeric/lib.php
index fb607a8cc16..acd8935de07 100644
--- a/mod/feedback/item/numeric/lib.php
+++ b/mod/feedback/item/numeric/lib.php
@@ -194,30 +194,33 @@ class feedback_item_numeric extends feedback_item_base {
//get the max-value
$range_to = (isset($range_from_to[1]) AND is_numeric($range_from_to[1])) ? floatval($range_from_to[1]) : 0;
$requiredmark = ($item->required == 1)?'* ':'';
- ?>
-
- label.') ';
- echo format_text($item->name . $requiredmark, true, false, false);
- switch(true) {
- case ($range_from === '-' AND is_numeric($range_to)):
- echo ' ('.get_string('maximal', 'feedback').': '.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_to).')';
- break;
- case (is_numeric($range_from) AND $range_to === '-'):
- echo ' ('.get_string('minimal', 'feedback').': '.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_from).')';
- break;
- case ($range_from === '-' AND $range_to === '-'):
- break;
- default:
- echo ' ('.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_from).' - '.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_to).')';
- break;
- }
- ?>
-
-
-
-
- ';
+ echo '('.$item->label.') ';
+ echo format_text($item->name . $requiredmark, true, false, false);
+ echo '';
+ switch(true) {
+ case ($range_from === '-' AND is_numeric($range_to)):
+ echo ' ('.get_string('maximal', 'feedback').': '.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_to).')';
+ break;
+ case (is_numeric($range_from) AND $range_to === '-'):
+ echo ' ('.get_string('minimal', 'feedback').': '.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_from).')';
+ break;
+ case ($range_from === '-' AND $range_to === '-'):
+ break;
+ default:
+ echo ' ('.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_from).' - '.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_to).')';
+ break;
+ }
+ echo ' ';
+ echo '';
+
+ //print the presentation
+ echo '';
+ echo '';
+ echo ' ';
+ echo ' ';
+ echo '
';
}
/**
@@ -240,34 +243,38 @@ class feedback_item_numeric extends feedback_item_base {
//get the max-value
$range_to = (isset($range_from_to[1]) AND is_numeric($range_from_to[1])) ? floatval($range_from_to[1]) : 0;
if($highlightrequire AND (!$this->check_value($value, $item))) {
- $highlight = 'bgcolor="#FFAAAA" class="missingrequire"';
+ $highlight = ' missingrequire';
}else {
$highlight = '';
}
$requiredmark = ($item->required == 1)?'* ':'';
- ?>
- valign="top" align="">
- name . $requiredmark, true, false, false);
- switch(true) {
- case ($range_from === '-' AND is_numeric($range_to)):
- echo ' ('.get_string('maximal', 'feedback').': '.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_to).')';
- break;
- case (is_numeric($range_from) AND $range_to === '-'):
- echo ' ('.get_string('minimal', 'feedback').': '.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_from).')';
- break;
- case ($range_from === '-' AND $range_to === '-'):
- break;
- default:
- echo ' ('.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_from).' - '.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_to).')';
- break;
- }
- ?>
-
-
-
-
- ';
+ echo format_text($item->name . $requiredmark, true, false, false);
+ echo '';
+ switch(true) {
+ case ($range_from === '-' AND is_numeric($range_to)):
+ echo ' ('.get_string('maximal', 'feedback').': '.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_to).')';
+ break;
+ case (is_numeric($range_from) AND $range_to === '-'):
+ echo ' ('.get_string('minimal', 'feedback').': '.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_from).')';
+ break;
+ case ($range_from === '-' AND $range_to === '-'):
+ break;
+ default:
+ echo ' ('.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_from).' - '.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_to).')';
+ break;
+ }
+ echo ' ';
+ echo '';
+
+ //print the presentation
+ echo '';
+ echo '';
+ echo ' ';
+ echo ' ';
+ echo '
';
}
/**
@@ -289,34 +296,32 @@ class feedback_item_numeric extends feedback_item_base {
//get the max-value
$range_to = (isset($range_from_to[1]) AND is_numeric($range_from_to[1])) ? floatval($range_from_to[1]) : 0;
$requiredmark = ($item->required == 1)?'* ':'';
- ?>
-
- label.') ';
- echo format_text($item->name . $requiredmark, true, false, false);
- switch(true) {
- case ($range_from === '-' AND is_numeric($range_to)):
- echo ' ('.get_string('maximal', 'feedback').': '.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_to).')';
- break;
- case (is_numeric($range_from) AND $range_to === '-'):
- echo ' ('.get_string('minimal', 'feedback').': '.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_from).')';
- break;
- case ($range_from === '-' AND $range_to === '-'):
- break;
- default:
- echo ' ('.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_from).' - '.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_to).')';
- break;
- }
- ?>
-
-
- ';
+ echo '('.$item->label.') ';
+ echo format_text($item->name . $requiredmark, true, false, false);
+ switch(true) {
+ case ($range_from === '-' AND is_numeric($range_to)):
+ echo ' ('.get_string('maximal', 'feedback').': '.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_to).')';
+ break;
+ case (is_numeric($range_from) AND $range_to === '-'):
+ echo ' ('.get_string('minimal', 'feedback').': '.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_from).')';
+ break;
+ case ($range_from === '-' AND $range_to === '-'):
+ break;
+ default:
+ echo ' ('.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_from).' - '.str_replace(FEEDBACK_DECIMAL, $this->sep_dec, $range_to).')';
+ break;
+ }
+ echo '';
+
+ //print the presentation
+ echo '';
echo $OUTPUT->box_start('generalbox boxalign'.$align);
echo (is_numeric($value)) ? number_format($value, 2, $this->sep_dec, $this->sep_thous) : ' ';
echo $OUTPUT->box_end();
- ?>
-
- ';
}
function check_value($value, $item) {
diff --git a/mod/feedback/item/textarea/lib.php b/mod/feedback/item/textarea/lib.php
index dc4b6388735..03d49403721 100644
--- a/mod/feedback/item/textarea/lib.php
+++ b/mod/feedback/item/textarea/lib.php
@@ -157,19 +157,18 @@ class feedback_item_textarea extends feedback_item_base {
$presentation = explode ("|", $item->presentation);
$requiredmark = ($item->required == 1)?'* ':'';
- ?>
-
- label.') ';
- echo format_text($item->name . $requiredmark, true, false, false);
- ?>
-
-
-
-
- ';
+ echo '('.$item->label.') ';
+ echo format_text($item->name.$requiredmark, true, false, false);
+ echo '';
+
+ //print the presentation
+ echo '';
+ echo '';
+ echo ' ';
+ echo ' ';
+ echo '
';
}
/**
@@ -187,23 +186,23 @@ class feedback_item_textarea extends feedback_item_base {
$presentation = explode ("|", $item->presentation);
if($highlightrequire AND $item->required AND strval($value) == '') {
- $highlight = 'bgcolor="#FFAAAA" class="missingrequire"';
+ $highlight = ' missingrequire';
}else {
$highlight = '';
}
$requiredmark = ($item->required == 1)?'* ':'';
- ?>
- valign="top" align="">
- ';
echo format_text($item->name . $requiredmark, true, false, false);
- ?>
-
-
-
-
- ';
+
+ //print the presentation
+ echo '';
+ echo '';
+ echo ''.($value ? htmlspecialchars($value) : '').' ';
+ echo ' ';
+ echo '
';
}
/**
@@ -220,21 +219,17 @@ class feedback_item_textarea extends feedback_item_base {
$presentation = explode ("|", $item->presentation);
$requiredmark = ($item->required == 1)?'* ':'';
- ?>
-
- ';
echo '('.$item->label.') ';
echo format_text($item->name . $requiredmark, true, false, false);
- ?>
-
-
- ';
+
+ //print the presentation
echo $OUTPUT->box_start('generalbox boxalign'.$align);
echo $value?str_replace("\n",' ',$value):' ';
echo $OUTPUT->box_end();
- ?>
-
- presentation);
$requiredmark = ($item->required == 1)?'* ':'';
- ?>
-
- label.') ';
- echo format_text($item->name . $requiredmark, true, false, false);
- ?>
-
-
-
-
- ';
+ echo '('.$item->label.') ';
+ echo format_text($item->name.$requiredmark, true, false, false);
+ echo '';
+
+ //print the presentation
+ echo '';
+ echo '';
+ echo ' ';
+ echo ' ';
+ echo '
';
}
/**
@@ -182,21 +183,23 @@ class feedback_item_textfield extends feedback_item_base {
$presentation = explode ("|", $item->presentation);
if($highlightrequire AND $item->required AND strval($value) == '') {
- $highlight = 'bgcolor="#FFAAAA" class="missingrequire"';
+ $highlight = ' missingrequire';
}else {
$highlight = '';
}
$requiredmark = ($item->required == 1)?'* ':'';
- ?>
- valign="top" align="">
- name . $requiredmark, true, false, false);
- ?>
-
-
-
-
- ';
+ echo format_text($item->name.$requiredmark, true, false, false);
+ echo '';
+
+ //print the presentation
+ echo '';
+ echo '';
+ echo ' ';
+ echo ' ';
+ echo '
';
}
/**
@@ -213,21 +216,15 @@ class feedback_item_textfield extends feedback_item_base {
$presentation = explode ("|", $item->presentation);
$requiredmark = ($item->required == 1)?'* ':'';
- ?>
- valign="top" align="">
- ';
echo '('.$item->label.') ';
echo format_text($item->name . $requiredmark, true, false, false);
- ?>
-
-
- ';
echo $OUTPUT->box_start('generalbox boxalign'.$align);
- echo $value?$value:' ';
+ echo $value ? $value : ' ';
echo $OUTPUT->box_end();
- ?>
-
- instance);
+ $params = array(FEEDBACK_ANONYMOUS_NO, $cm->instance);
$fromgroup = '';
$wheregroup = '';
@@ -727,7 +727,7 @@ function feedback_get_complete_users($cm, $group = false) {
$params[] = $group;
}
$sql = 'SELECT DISTINCT u.* FROM {user} u, {feedback_completed} c'.$fromgroup.'
- WHERE u.id = c.userid AND c.feedback = ?
+ WHERE anonymous_response = ? AND u.id = c.userid AND c.feedback = ?
'.$wheregroup.'
ORDER BY u.lastname';
return $DB->get_records_sql($sql, $params);
diff --git a/mod/feedback/show_entries_anonym.php b/mod/feedback/show_entries_anonym.php
index e35dcfda59a..a54ce080ed4 100644
--- a/mod/feedback/show_entries_anonym.php
+++ b/mod/feedback/show_entries_anonym.php
@@ -87,32 +87,34 @@ echo $OUTPUT->box_start('generalbox boxaligncenter boxwidthwide');
$PAGE->requires->js('/mod/feedback/feedback.js');
?>
-
-
-
-
-
-
-completedid) AND $formdata->completedid == $compl->id)?'selected="selected"':'';
- echo ''.get_string('response_nr', 'feedback').': '. $compl->random_response. ' ';//arb
- $num++;
+
+
+
+
+
+
+
+ completedid) AND $formdata->completedid == $compl->id)?'selected="selected"':'';
+ echo ''.get_string('response_nr', 'feedback').': '. $compl->random_response. ' ';//arb
+ $num++;
+ }
}
- }
-?>
-
-
-
-
-
-
-
-
-
-
+ ?>
+
+
+
+
+
+
+
+
+
+
+
showanonym) && $formdata->showanonym == FEEDBACK_ANONYMOUS_Y
$feedbackitems = $DB->get_records('feedback_item', array('feedback'=>$feedback->id), 'position');
$feedbackcompleted = $DB->get_record('feedback_completed', array('id'=>$formdata->completedid));
if(is_array($feedbackitems)){
+ $align = right_to_left() ? 'right' : 'left';
+
if($feedbackcompleted) {
- echo ''.get_string('chosen_feedback_response', 'feedback').' ('.get_string('anonymous', 'feedback').')
';//arb
+ echo '';
+ echo get_string('chosen_feedback_response', 'feedback');
+ echo '
';
+ echo '';
+ echo '('.get_string('anonymous', 'feedback').')';
+ echo '
';
} else {
- echo ''.get_string('not_completed_yet','feedback').'
';
+ echo '';
+ echo get_string('not_completed_yet','feedback');
+ echo '
';
}
- echo $OUTPUT->box_start('generalbox boxaligncenter boxwidthnormal');
- echo ' ';
- echo ' ';
- echo '';
+
+ echo '';
+ // echo $OUTPUT->box_start('generalbox boxaligncenter boxwidthnormal');
$itemnr = 0;
foreach($feedbackitems as $feedbackitem){
//get the values
$value = $DB->get_record('feedback_value', array('completed'=>$feedbackcompleted->id, 'item'=>$feedbackitem->id));
- echo '
';
+ echo '';
if($feedbackitem->hasvalue == 1 AND $feedback->autonumbering) {
$itemnr++;
- echo '
' . $itemnr . '. ';
- } else {
- echo '
';
+ echo '
' . $itemnr . '
';
}
if($feedbackitem->typ != 'pagebreak') {
+ echo '
';
$itemvalue = isset($value->value) ? $value->value : false;
feedback_print_item_show_value($feedbackitem, $itemvalue);
- }else {
- echo '
';
+ echo '';
}
- echo '
';
+ echo '
';
}
- echo '';
- echo ' ';
- echo '
';
- echo ' ';
- echo $OUTPUT->box_end();
+ // echo $OUTPUT->box_end();
+ echo '';
}
}
/// Finish the page
diff --git a/mod/feedback/styles.css b/mod/feedback/styles.css
index 2cfc1968d8b..6e062161b19 100644
--- a/mod/feedback/styles.css
+++ b/mod/feedback/styles.css
@@ -6,4 +6,64 @@
.feedback_switchrequired img{
}
+div.missingrequire {
+ background:#FFAAAA;
+}
+div.feedback_item_box_left, div.feedback_item_box_right {
+}
+
+div.feedback_item_number_left, div.feedback_item_left {
+ float:left;
+}
+div.feedback_item_number_right, div.feedback_item_right {
+ float:right;
+}
+
+div.feedback_item_commands_left {
+ float:right;
+ text-align:right;
+}
+
+div.feedback_item_commands_right {
+ float:left;
+ text-align:left;
+}
+
+li.feedback_item_check_h_left,
+li.feedback_item_check_h_right,
+li.feedback_item_select_h_left,
+li.feedback_item_select_h_right,
+li.feedback_item_radio_h_left,
+li.feedback_item_radio_h_right{
+ list-style-type:none;
+ display:inline;
+}
+
+li.feedback_item_check_v_left,
+li.feedback_item_check_v_right,
+li.feedback_item_select_v_left,
+li.feedback_item_select_v_right,
+li.feedback_item_radio_v_left,
+li.feedback_item_radio_v_right{
+ list-style-type:none;
+ display:block;
+}
+
+div.feedback_item_captcha_text_left,
+div.feedback_item_captcha_img_left {
+ display:inline;
+ margin: 5px;
+}
+div.feedback_item_captcha_text_right,
+div.feedback_item_captcha_img_right {
+ display:inline;
+ margin: 5px;
+}
+
+hr.feedback_pagebreak {
+ height:8px;
+ color:#aaaaaa;
+ background-color:#aaaaaa;
+ border:0px;
+}
\ No newline at end of file