L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-34401 Replace ad-hoc plugin request caches with proper application caches

Browse Source 
Data cached in these caches change only at well defined places (during
need for upgrade checks, at the plugin management screen etc). So it
makes sense to use proper application caches instead of request caches.

This saves couple of database queries at almost every page in Moodle.
This commit is contained in:
David Mudrák
2013-03-11 12:48:53 +01:00
parent b8a6f26ee3
commit ad3ed98b05
11 changed files with 89 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/pluginlib.php
+6 -12
View File
@@ -2479,8 +2479,7 @@ abstract class plugininfo_base {
protected function get_version_from_config_plugins($plugin, $disablecache=false) {
global $DB;
$cache = cache::make_from_params(cache_store::MODE_REQUEST, 'core_plugin', 'plugininfo_base',
array(), array('simplekeys' => true, 'simpledata' => true));
$cache = cache::make('core', 'plugininfo_base');
$pluginversions = $cache->get('versions_db');
@@ -2641,8 +2640,7 @@ class plugininfo_block extends plugininfo_base {
protected static function get_blocks_info($disablecache=false) {
global $DB;
$cache = cache::make_from_params(cache_store::MODE_REQUEST, 'core_plugin', 'plugininfo_block',
array(), array('simplekeys' => true, 'simpledata' => true));
$cache = cache::make('core', 'plugininfo_block');
$blocktypes = $cache->get('blocktypes');
@@ -2786,8 +2784,7 @@ class plugininfo_filter extends plugininfo_base {
protected static function get_global_states($disablecache=false) {
global $DB;
$cache = cache::make_from_params(cache_store::MODE_REQUEST, 'core_plugin', 'plugininfo_filter',
array(), array('simplekeys' => true, 'simpledata' => true));
$cache = cache::make('core', 'plugininfo_filter');
$globalstates = $cache->get('globalstates');
@@ -2958,8 +2955,7 @@ class plugininfo_mod extends plugininfo_base {
protected static function get_modules_info($disablecache=false) {
global $DB;
$cache = cache::make_from_params(cache_store::MODE_REQUEST, 'core_plugin', 'plugininfo_mod',
array(), array('simplekeys' => true, 'simpledata' => true));
$cache = cache::make('core', 'plugininfo_mod');
$modulesinfo = $cache->get('modulesinfo');
@@ -3220,8 +3216,7 @@ class plugininfo_repository extends plugininfo_base {
protected static function get_enabled_repositories($disablecache=false) {
global $DB;
$cache = cache::make_from_params(cache_store::MODE_REQUEST, 'core_plugin', 'plugininfo_repository',
array(), array('simplekeys' => true, 'simpledata' => true));
$cache = cache::make('core', 'plugininfo_repository');
$enabled = $cache->get('enabled');
@@ -3259,8 +3254,7 @@ class plugininfo_portfolio extends plugininfo_base {
protected static function get_enabled_portfolios($disablecache=false) {
global $DB;
$cache = cache::make_from_params(cache_store::MODE_REQUEST, 'core_plugin', 'plugininfo_portfolio',
array(), array('simplekeys' => true, 'simpledata' => true));
$cache = cache::make('core', 'plugininfo_portfolio');
$enabled = $cache->get('enabled');