From ad2fc9d060588760ea14b7ad045e5de448d1fc1b Mon Sep 17 00:00:00 2001 From: Dan Poltawski Date: Wed, 14 Aug 2013 10:46:19 +0800 Subject: [PATCH] MDL-41157 calendar: improve calendar_get_course_cached The function get_course() introduced in 2.5.1 will use $COURSE and $SITE to avoid an uncessary DB query, simplifying the logic of this function and improving perf. --- calendar/lib.php | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/calendar/lib.php b/calendar/lib.php index 371b7ecb966..b359beba266 100644 --- a/calendar/lib.php +++ b/calendar/lib.php @@ -1391,14 +1391,8 @@ function calendar_get_module_cached(&$coursecache, $modulename, $instance) { * @return stdClass $coursecache[$courseid] return the specific course cache */ function calendar_get_course_cached(&$coursecache, $courseid) { - global $COURSE, $DB; - if (!isset($coursecache[$courseid])) { - if ($courseid == $COURSE->id) { - $coursecache[$courseid] = $COURSE; - } else { - $coursecache[$courseid] = $DB->get_record('course', array('id'=>$courseid)); - } + $coursecache[$courseid] = get_course($courseid); } return $coursecache[$courseid]; }