From da7c844c30894e2a88a4b68e4de8db97122d361c Mon Sep 17 00:00:00 2001 From: sam marshall Date: Tue, 10 Sep 2013 16:34:44 +0100 Subject: [PATCH] MDL-38194 Files: Allow download of large backup files The PHP readfile function does not work for files more than 2GB. This commit provides a wrapper that can be used so that files less than 2GB are sent with readfile, and files larger than 2GB are sent manually. The change applies to all uses of pluginfile.php, although in reality, backup files are probably the only ones likely to be more than two gigabytes. --- lib/filelib.php | 39 ++++++++++++++++++++++++++++++++- lib/filestorage/stored_file.php | 2 +- 2 files changed, 39 insertions(+), 2 deletions(-) diff --git a/lib/filelib.php b/lib/filelib.php index 5398f379dff..17c0c5511fe 100644 --- a/lib/filelib.php +++ b/lib/filelib.php @@ -1983,6 +1983,43 @@ function send_header_404() { } } +/** + * The readfile function can fail when files are larger than 2GB (even on 64-bit + * platforms). This wrapper uses readfile for small files and custom code for + * large ones. + * + * @param string $path Path to file + * @param int $filesize Size of file (if left out, will get it automatically) + * @return int|bool Size read (will always be $filesize) or false if failed + */ +function readfile_allow_large($path, $filesize = -1) { + // Automatically get size if not specified. + if ($filesize === -1) { + $filesize = filesize($path); + } + if ($filesize <= 2147483647) { + // If the file is up to 2^31 - 1, send it normally using readfile. + return readfile($path); + } else { + // For large files, read and output in 64KB chunks. + $handle = fopen($path, 'r'); + if ($handle === false) { + return false; + } + $left = $filesize; + while ($left > 0) { + $size = min($left, 65536); + $buffer = fread($handle, $size); + if ($buffer === false) { + return false; + } + echo $buffer; + $left -= $size; + } + return $filesize; + } +} + /** * Enhanced readfile() with optional acceleration. * @param string|stored_file $file @@ -2105,7 +2142,7 @@ function readfile_accel($file, $mimetype, $accelerate) { if (is_object($file)) { $file->readfile(); } else { - readfile($file); + readfile_allow_large($file, $filesize); } } diff --git a/lib/filestorage/stored_file.php b/lib/filestorage/stored_file.php index 40c5b314147..6041919d1d2 100644 --- a/lib/filestorage/stored_file.php +++ b/lib/filestorage/stored_file.php @@ -401,7 +401,7 @@ class stored_file { throw new file_exception('storedfilecannotread', '', $path); } } - readfile($path); + readfile_allow_large($path, $this->get_filesize()); } /**