From 6cc27fbb7340c3a933c95d50b4726844b17ac213 Mon Sep 17 00:00:00 2001 From: Paul Holden Date: Thu, 11 Jan 2024 11:43:15 +0000 Subject: [PATCH] MDL-80575 mod_forum: correct field name for "Notify students" setting. --- mod/forum/mod_form.php | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/mod/forum/mod_form.php b/mod/forum/mod_form.php index d1b194e2980..de17b42026a 100644 --- a/mod/forum/mod_form.php +++ b/mod/forum/mod_form.php @@ -232,8 +232,6 @@ class mod_forum_mod_form extends moodleform_mod { $gradefieldname = component_gradeitems::get_field_name_for_itemnumber($component, $itemnumber, 'grade'); $gradecatfieldname = component_gradeitems::get_field_name_for_itemnumber($component, $itemnumber, 'gradecat'); $gradepassfieldname = component_gradeitems::get_field_name_for_itemnumber($component, $itemnumber, 'gradepass'); - $sendstudentnotificationsfieldname = component_gradeitems::get_field_name_for_itemnumber($component, $itemnumber, - 'sendstudentnotifications'); // The advancedgradingmethod is different in that it is suffixed with an area name... which is not the // itemnumber. @@ -304,13 +302,9 @@ class mod_forum_mod_form extends moodleform_mod { $mform->setType($gradepassfieldname, PARAM_RAW); $mform->hideIf($gradepassfieldname, "{$gradefieldname}[modgrade_type]", 'eq', 'none'); - $mform->addElement( - 'selectyesno', - $sendstudentnotificationsfieldname, - get_string('sendstudentnotificationsdefault', 'forum') - ); - $mform->addHelpButton($sendstudentnotificationsfieldname, 'sendstudentnotificationsdefault', 'forum'); - $mform->hideIf($sendstudentnotificationsfieldname, "{$gradefieldname}[modgrade_type]", 'eq', 'none'); + $mform->addElement('selectyesno', 'grade_forum_notify', get_string('sendstudentnotificationsdefault', 'forum')); + $mform->addHelpButton('grade_forum_notify', 'sendstudentnotificationsdefault', 'forum'); + $mform->hideIf('grade_forum_notify', "{$gradefieldname}[modgrade_type]", 'eq', 'none'); } function definition_after_data() {