From ab12596a7b83c0d07f3db402d0a4d8e1f04d79a5 Mon Sep 17 00:00:00 2001
From: Jake Dallimore <jake@moodle.com>
Date: Wed, 10 May 2023 11:07:48 +0800
Subject: [PATCH] MDL-76842 enrol_lti: fix user record updates in
 user_repository

Only call user_update_user when the relevant user data has changed,
preventing unnecessary user_updated events. This also removes the
line setting timemodified on the user since user_update_user already
handles this.
---
 .../repository/user_repository.php            | 25 ++++++++++++++++---
 1 file changed, 21 insertions(+), 4 deletions(-)

diff --git a/enrol/lti/classes/local/ltiadvantage/repository/user_repository.php b/enrol/lti/classes/local/ltiadvantage/repository/user_repository.php
index de0a7594096..16829cafada 100644
--- a/enrol/lti/classes/local/ltiadvantage/repository/user_repository.php
+++ b/enrol/lti/classes/local/ltiadvantage/repository/user_repository.php
@@ -162,10 +162,18 @@ class user_repository {
                     "to user '{$ltiuser->userid}' and can't be associated with another user '{$userrecord->id}'.");
             }
 
-            $userrecord->timemodified = $timenow;
-            $ltiuserrecord->timemodified = $timenow;
-            \user_update_user($userrecord);
+            // Only update the Moodle user record if something has changed.
+            $rawuser = \core_user::get_user($userrecord->id);
+            $userfieldstocompare = array_intersect_key(
+                (array) $rawuser,
+                (array) $userrecord
+            );
+            if (!empty(array_diff((array) $userrecord, $userfieldstocompare))) {
+                \user_update_user($userrecord);
+            }
             unset($userrecord->id);
+
+            $ltiuserrecord->timemodified = $timenow;
             $DB->update_record($this->ltiuserstable, $ltiuserrecord);
         } else {
             // Validate uniqueness of the lti user, in the case of a stale object coming in to be saved.
@@ -173,8 +181,17 @@ class user_repository {
                 throw new \coding_exception("Cannot create duplicate LTI user '{$user->get_localid()}' for resource " .
                     "'{$user->get_resourceid()}'.");
             }
+
+            // Only update the Moodle user record if something has changed.
             $userid = $userrecord->id;
-            \user_update_user($userrecord);
+            $rawuser = \core_user::get_user($userid);
+            $userfieldstocompare = array_intersect_key(
+                (array) $rawuser,
+                (array) $userrecord
+            );
+            if (!empty(array_diff((array) $userrecord, $userfieldstocompare))) {
+                \user_update_user($userrecord);
+            }
             unset($userrecord->id);
 
             // Create the lti_user record, holding details that have a lifespan equal to that of the enrolment instance.