From aad5b7f1d020dd63845b8a8d00a389406ef20d55 Mon Sep 17 00:00:00 2001 From: sam marshall Date: Wed, 24 Jun 2015 11:09:27 +0100 Subject: [PATCH] MDL-49434 availability: Revert MDL-49418 (obsoleted by this change) This reverts commit 51fef1de359439c79fa98bd9ebec19077e66cb57. --- lib/moodlelib.php | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/lib/moodlelib.php b/lib/moodlelib.php index c33fc8f351c..574225b2703 100644 --- a/lib/moodlelib.php +++ b/lib/moodlelib.php @@ -2807,15 +2807,6 @@ function require_login($courseorid = null, $autologinguest = true, $cm = null, $ } } - // Set the global $COURSE. - // TODO MDL-49434: setting current course/cm should be after the check $cm->uservisible . - if ($cm) { - $PAGE->set_cm($cm, $course); - $PAGE->set_pagelayout('incourse'); - } else if (!empty($courseorid)) { - $PAGE->set_course($course); - } - // Check visibility of activity to current user; includes visible flag, conditional availability, etc. if ($cm && !$cm->uservisible) { if ($preventredirect) { @@ -2829,6 +2820,14 @@ function require_login($courseorid = null, $autologinguest = true, $cm = null, $ redirect($url, get_string('activityiscurrentlyhidden')); } + // Set the global $COURSE. + if ($cm) { + $PAGE->set_cm($cm, $course); + $PAGE->set_pagelayout('incourse'); + } else if (!empty($courseorid)) { + $PAGE->set_course($course); + } + // Finally access granted, update lastaccess times. user_accesstime_log($course->id); }